Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: components/update_client/background_downloader_win.cc

Issue 2322733002: Remove DCHECK from the component updater background downloader code. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/update_client/background_downloader_win.cc
diff --git a/components/update_client/background_downloader_win.cc b/components/update_client/background_downloader_win.cc
index 20d75c3e57a16e43d78d80701895125a586ae0d0..4d3790ed0b42347092eb434096bf302269bc3953 100644
--- a/components/update_client/background_downloader_win.cc
+++ b/components/update_client/background_downloader_win.cc
@@ -12,6 +12,7 @@
#include <functional>
#include <iomanip>
#include <limits>
+#include <memory>
#include <utility>
#include <vector>
@@ -873,8 +874,8 @@ HRESULT BackgroundDownloader::ClearGit() {
};
for (auto cookie : cookies) {
- hr = git->RevokeInterfaceFromGlobal(cookie);
- DCHECK(SUCCEEDED(hr));
+ // TODO(sorin): check the result of the call, see crbug.com/644857.
+ git->RevokeInterfaceFromGlobal(cookie);
}
return S_OK;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698