Add support for <basic-shape> to 'clip-path' on SVG elements

Add support for <basic-shape> to 'clip-path' on SVG elements

Use ClipPathOperation as storage for the property in SVGComputedStyle,
and add support for <basic-shape>s where needed. This also means that
nesting a <clipPath> with a <basic-shape> is added.
Since SVGPaintContext::applyClipIfNecessary can't fail in a useful way,
just drop the returned bool (test added.) An invalid clip-path will
just be ignored (per spec.)

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/f4431bff28115f98687623c8ff242d2fc4e989ff
Cr-Commit-Position: refs/heads/master@{#418387}

[fs, 2016-09-09 16:25:12]

Description was changed from

==========
Add support for <basic-shape> to 'clip-path' on SVG elements

Use ClipPathOperation as storage for the property in SVGComputedStyle,
and add support for <basic-shape>s where needed. This also means that
nesting a <clipPath> with a <basic-shape> is added.
Since SVGPaintContext::applyClipIfNecessary can't fail in a useful way,
just drop the returned bool (test added.) An invalid clip-path will
just be ignored (per spec.)

BUG=633028
==========

to

==========
Add support for <basic-shape> to 'clip-path' on SVG elements

Use ClipPathOperation as storage for the property in SVGComputedStyle,
and add support for <basic-shape>s where needed. This also means that
nesting a <clipPath> with a <basic-shape> is added.
Since SVGPaintContext::applyClipIfNecessary can't fail in a useful way,
just drop the returned bool (test added.) An invalid clip-path will
just be ignored (per spec.)

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[fs, 2016-09-09 16:25:19]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 16:25:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 17:14:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 17:14:34]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[fs, 2016-09-09 19:04:42]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 19:05:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2016-09-09 20:10:32]

fs@opera.com changed reviewers:
+ chrishtr@chromium.org, pdr@chromium.org

[commit-bot: I haz the power, 2016-09-09 20:49:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 20:49:35]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[Stephen Chennney, 2016-09-09 20:50:37]

schenney@chromium.org changed reviewers:
+ schenney@chromium.org

[Stephen Chennney, 2016-09-09 20:50:37]

No test for just plain basic shapes as an SVG clip path? I see the nested test.

As I understand it you can specify nesting a basic shape within an SVG path
because the basic shape can only be attached to the initial <clip-path >
element. Is that right?

[Stephen Chennney, 2016-09-09 20:53:39]

On 2016/09/09 20:50:37, Stephen Chennney wrote:
> No test for just plain basic shapes as an SVG clip path? I see the nested
test.
> 
> As I understand it you can specify nesting a basic shape within an SVG path
> because the basic shape can only be attached to the initial <clip-path >
> element. Is that right?

Sorry, not "you can specify" but "you cannot specify".

[fs, 2016-09-09 21:01:41]

On 2016/09/09 at 20:53:39, schenney wrote:
> On 2016/09/09 20:50:37, Stephen Chennney wrote:
> > No test for just plain basic shapes as an SVG clip path? I see the nested
test.

We have tests for -webkit-clip-path w/ <basic-shape> on SVG, and considering the
near-imminent merge of the two I didn't want to add any new tests for the
'clip-path' case. The code is literally the same too. Later I'll probably do a
clean-up pass on some of the tests to drop the prefix.

> > As I understand it you can specify nesting a basic shape within an SVG path
> > because the basic shape can only be attached to the initial <clip-path >
> > element. Is that right?
> 
> Sorry, not "you can specify" but "you cannot specify".

Right, you cannot nest from a <basic-shape> (so it's essentially a leaf.)

[Stephen Chennney, 2016-09-12 13:35:15]

lgtm

[fs, 2016-09-13 19:13:13]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 19:13:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 21:03:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 21:03:32]

Dry run: This issue passed the CQ dry run.

[fs, 2016-09-13 21:59:28]

The CQ bit was checked by fs@opera.com

[fs, 2016-09-13 21:59:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
schenney@chromium.org
Link to the patchset: https://codereview.chromium.org/2322343003/#ps30001
(title: "Update SPv2 expectations")

[commit-bot: I haz the power, 2016-09-13 21:59:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 22:06:03]

Committed patchset #3 (id:30001)

[commit-bot: I haz the power, 2016-09-13 22:07:20]

Description was changed from

==========
Add support for <basic-shape> to 'clip-path' on SVG elements

Use ClipPathOperation as storage for the property in SVGComputedStyle,
and add support for <basic-shape>s where needed. This also means that
nesting a <clipPath> with a <basic-shape> is added.
Since SVGPaintContext::applyClipIfNecessary can't fail in a useful way,
just drop the returned bool (test added.) An invalid clip-path will
just be ignored (per spec.)

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Add support for <basic-shape> to 'clip-path' on SVG elements

Use ClipPathOperation as storage for the property in SVGComputedStyle,
and add support for <basic-shape>s where needed. This also means that
nesting a <clipPath> with a <basic-shape> is added.
Since SVGPaintContext::applyClipIfNecessary can't fail in a useful way,
just drop the returned bool (test added.) An invalid clip-path will
just be ignored (per spec.)

BUG=633028
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/f4431bff28115f98687623c8ff242d2fc4e989ff
Cr-Commit-Position: refs/heads/master@{#418387}
==========

[commit-bot: I haz the power, 2016-09-13 22:07:21]

Patchset 3 (id:??) landed as
https://crrev.com/f4431bff28115f98687623c8ff242d2fc4e989ff
Cr-Commit-Position: refs/heads/master@{#418387}