third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp - Issue 2322343003: Add support for <basic-shape> to 'clip-path' on SVG elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

Issue 2322343003: Add support for <basic-shape> to 'clip-path' on SVG elements (Closed)

Patch Set: Update SPv2 expectations Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp ('k') | third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

index f6665cf63897ea5b837b540b36c9e74b9685168d..11000e008bb0b2f8ab417d55bb67e2a2a709fe5c 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceClipper.cpp

@@ -66,7 +66,7 @@ bool LayoutSVGResourceClipper::calculateClipContentPathIfNeeded()

return true;

// If the current clip-path gets clipped itself, we have to fallback to masking.

- if (style()->svgStyle().hasClipper())

+ if (style()->svgStyle().clipPath())

return false;

unsigned opCount = 0;

@@ -90,7 +90,7 @@ bool LayoutSVGResourceClipper::calculateClipContentPathIfNeeded()

continue;

// Current shape in clip-path gets clipped too. Fallback to masking.

- if (style->svgStyle().hasClipper()) {

+ if (style->svgStyle().clipPath()) {

m_clipContentPath.clear();

return false;

}