third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp - Issue 2322343003: Add support for <basic-shape> to 'clip-path' on SVG elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

Issue 2322343003: Add support for <basic-shape> to 'clip-path' on SVG elements (Closed)

Patch Set: Update SPv2 expectations Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSProperties.in ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

index 23d3b172a14fb8cf40de6a0d323e4f1704f79f85..d976d6a38e2683525bcb516655afa4ae813140ac 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

+++ b/third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp

@@ -2651,7 +2651,9 @@ const CSSValue* ComputedStyleCSSValueMapping::get(CSSPropertyID propertyID, cons

case CSSPropertyCounterReset:

return valueForCounterDirectives(style, propertyID);

case CSSPropertyWebkitClipPath:

- if (ClipPathOperation* operation = style.clipPath()) {

+ case CSSPropertyClipPath:

+ if (ClipPathOperation* operation = propertyID == CSSPropertyWebkitClipPath

+ ? style.clipPath() : style.svgStyle().clipPath()) {

if (operation->type() == ClipPathOperation::SHAPE)

return valueForBasicShape(style, toShapeClipPathOperation(operation)->basicShape());

if (operation->type() == ClipPathOperation::REFERENCE)

@@ -2847,10 +2849,6 @@ const CSSValue* ComputedStyleCSSValueMapping::get(CSSPropertyID propertyID, cons

return CSSPrimitiveValue::create(svgStyle.dominantBaseline());

case CSSPropertyTextAnchor:

return CSSPrimitiveValue::create(svgStyle.textAnchor());

- case CSSPropertyClipPath:

- if (!svgStyle.clipperResource().isEmpty())

- return CSSURIValue::create(serializeAsFragmentIdentifier(svgStyle.clipperResource()));

- return CSSPrimitiveValue::createIdentifier(CSSValueNone);

case CSSPropertyMask:

if (!svgStyle.maskerResource().isEmpty())

return CSSURIValue::create(serializeAsFragmentIdentifier(svgStyle.maskerResource()));