Refactor ElementShadow by separating v0 related features as ElementShadowV0

Refactor ElementShadow by separating v0 related features as ElementShadowV0

Introduces ElementShadowV0, separated from ElementShadow, to make the role of
ElementShadow clear. The clear separation of v0 APIs and v1 APIS would prevent a
misusage of ElementShadow.

ElementShadowV0 is created only for v0 shadow trees. Thus, ElementShadow will be a
light-weight object for v1 shadow trees.

BUG=624724
Committed: https://crrev.com/76384394c1e14fda6f4bc0f3cae50563a136cbaa
Cr-Commit-Position: refs/heads/master@{#418198}

[hayato, 2016-09-09 09:14:47]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 09:15:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2016-09-09 09:17:11]

WIP

[hayato, 2016-09-09 09:17:15]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 09:17:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 09:45:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 09:45:05]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hayato, 2016-09-09 09:47:54]

Description was changed from

==========
WIP: Refactor ElementShadow

BUG=
==========

to

==========
WIP: Refactor ElementShadow

BUG=624724
==========

[hayato, 2016-09-13 04:14:38]

update

[hayato, 2016-09-13 04:14:40]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 04:14:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 05:38:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 05:38:21]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[hayato, 2016-09-13 06:27:22]

minor

[hayato, 2016-09-13 06:27:25]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 06:27:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2016-09-13 06:38:03]

Description was changed from

==========
WIP: Refactor ElementShadow

BUG=624724
==========

to

==========
Refactor ElementShadow by separating v0 related features as ElementShadowV0

Introduces ElementShadowV0, separated from ElementShadow, to make the role of
ElementShadow clear. The clear separation of APIs would prevent the misusage of
ElementShadow.

ElementShadowV0 is created only for v0 shadow trees.
Thus, the memory usage would be reduced for v1 shadow trees.

BUG=624724
==========

[hayato, 2016-09-13 06:38:25]

Description was changed from

==========
Refactor ElementShadow by separating v0 related features as ElementShadowV0

Introduces ElementShadowV0, separated from ElementShadow, to make the role of
ElementShadow clear. The clear separation of APIs would prevent the misusage of
ElementShadow.

ElementShadowV0 is created only for v0 shadow trees.
Thus, the memory usage would be reduced for v1 shadow trees.

BUG=624724
==========

to

==========
Refactor ElementShadow by separating v0 related features as ElementShadowV0

Introduces ElementShadowV0, separated from ElementShadow, to make the role of
ElementShadow clear. The clear separation of APIs would prevent a misusage of
ElementShadow.

ElementShadowV0 is created only for v0 shadow trees.
Thus, the memory usage would be reduced for v1 shadow trees.

BUG=624724
==========

[hayato, 2016-09-13 06:39:19]

Description was changed from

==========
Refactor ElementShadow by separating v0 related features as ElementShadowV0

Introduces ElementShadowV0, separated from ElementShadow, to make the role of
ElementShadow clear. The clear separation of APIs would prevent a misusage of
ElementShadow.

ElementShadowV0 is created only for v0 shadow trees.
Thus, the memory usage would be reduced for v1 shadow trees.

BUG=624724
==========

to

==========
Refactor ElementShadow by separating v0 related features as ElementShadowV0

Introduces ElementShadowV0, separated from ElementShadow, to make the role of
ElementShadow clear. The clear separation of APIs would prevent a misusage of
ElementShadow.

ElementShadowV0 is created only for v0 shadow trees. Thus, ElementShadow will be
a light-weight object for v1 shadow trees.

BUG=624724
==========

[hayato, 2016-09-13 06:39:32]

Description was changed from

==========
Refactor ElementShadow by separating v0 related features as ElementShadowV0

Introduces ElementShadowV0, separated from ElementShadow, to make the role of
ElementShadow clear. The clear separation of APIs would prevent a misusage of
ElementShadow.

ElementShadowV0 is created only for v0 shadow trees. Thus, ElementShadow will be
a light-weight object for v1 shadow trees.

BUG=624724
==========

to

==========
Refactor ElementShadow by separating v0 related features as ElementShadowV0

Introduces ElementShadowV0, separated from ElementShadow, to make the role of
ElementShadow clear. The clear separation of APIs would prevent a misusage of
ElementShadow.

ElementShadowV0 is created only for v0 shadow trees. Thus, ElementShadow will be
a
light-weight object for v1 shadow trees.

BUG=624724
==========

[hayato, 2016-09-13 06:50:05]

Description was changed from

==========
Refactor ElementShadow by separating v0 related features as ElementShadowV0

Introduces ElementShadowV0, separated from ElementShadow, to make the role of
ElementShadow clear. The clear separation of APIs would prevent a misusage of
ElementShadow.

ElementShadowV0 is created only for v0 shadow trees. Thus, ElementShadow will be
a
light-weight object for v1 shadow trees.

BUG=624724
==========

to

==========
Refactor ElementShadow by separating v0 related features as ElementShadowV0

Introduces ElementShadowV0, separated from ElementShadow, to make the role of
ElementShadow clear. The clear separation of v0 APIs and v1 APIS would prevent a
misusage of ElementShadow.

ElementShadowV0 is created only for v0 shadow trees. Thus, ElementShadow will be
a
light-weight object for v1 shadow trees.

BUG=624724
==========

[hayato, 2016-09-13 06:50:28]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org, tkent@chromium.org

[hayato, 2016-09-13 06:50:29]

PTAL

[tkent, 2016-09-13 07:09:45]

lgtm

https://codereview.chromium.org/2322213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/shadow/ElementShadow.h (left):

https://codereview.chromium.org/2322213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/shadow/ElementShadow.h:1: /*
To me this file doesn't look a new file.  Probably we should not change the
copyright header.

https://codereview.chromium.org/2322213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp (right):

https://codereview.chromium.org/2322213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp:34: 
nit: The blank line is unnecessary.

[hayato, 2016-09-13 07:14:06]

addressed

[hayato, 2016-09-13 07:14:07]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 07:14:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2016-09-13 07:14:57]

Thank you for the review.

https://codereview.chromium.org/2322213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/shadow/ElementShadow.h (left):

https://codereview.chromium.org/2322213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/shadow/ElementShadow.h:1: /*
Sure. Done.

https://codereview.chromium.org/2322213002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp (right):

https://codereview.chromium.org/2322213002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/shadow/InsertionPoint.cpp:34: 
Done

[hayato, 2016-09-13 07:15:01]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2016-09-13 07:15:03]

The CQ bit was checked by hayato@chromium.org

[hayato, 2016-09-13 07:15:04]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2322213002/#ps80001
(title: "addressed")

[commit-bot: I haz the power, 2016-09-13 07:15:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kochi, 2016-09-13 07:37:04]

lgtm

[commit-bot: I haz the power, 2016-09-13 08:43:12]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-13 08:44:55]

Description was changed from

==========
Refactor ElementShadow by separating v0 related features as ElementShadowV0

Introduces ElementShadowV0, separated from ElementShadow, to make the role of
ElementShadow clear. The clear separation of v0 APIs and v1 APIS would prevent a
misusage of ElementShadow.

ElementShadowV0 is created only for v0 shadow trees. Thus, ElementShadow will be
a
light-weight object for v1 shadow trees.

BUG=624724
==========

to

==========
Refactor ElementShadow by separating v0 related features as ElementShadowV0

Introduces ElementShadowV0, separated from ElementShadow, to make the role of
ElementShadow clear. The clear separation of v0 APIs and v1 APIS would prevent a
misusage of ElementShadow.

ElementShadowV0 is created only for v0 shadow trees. Thus, ElementShadow will be
a
light-weight object for v1 shadow trees.

BUG=624724

Committed: https://crrev.com/76384394c1e14fda6f4bc0f3cae50563a136cbaa
Cr-Commit-Position: refs/heads/master@{#418198}
==========

[commit-bot: I haz the power, 2016-09-13 08:44:56]

Patchset 5 (id:??) landed as
https://crrev.com/76384394c1e14fda6f4bc0f3cae50563a136cbaa
Cr-Commit-Position: refs/heads/master@{#418198}