Fix build on Solaris and musl-based platforms

Fix build on Solaris and musl-based platforms

Use a similar approach to Chromium [1] to allow platforms that don't have
execinfo.h to build.
Because Solaris has it, add this platform to the condition.

[1] https://cs.chromium.org/chromium/src/base/debug/stack_trace_posix.cc

BUG=
R=rmcilroy@chromium.org

[targos, 2016-09-07 08:13:58]

mic.besace@gmail.com changed reviewers:
+ ofrobots@google.com

[rmcilroy, 2016-09-07 11:06:22]

Thanks for the CL, a couple of comments.

https://codereview.chromium.org/2321433003/diff/1/src/base/debug/stack_trace.cc
File src/base/debug/stack_trace.cc (right):

https://codereview.chromium.org/2321433003/diff/1/src/base/debug/stack_trace....
src/base/debug/stack_trace.cc:34: #if V8_LIBC_GLIBC || V8_OS_BSD ||
V8_OS_SOLARIS
This will avoid printing on windows also which is wrong. The corresponding
change in Chromium is "#if !defined(__UCLIBC__)". Do you even need this though
(the CL mentions Solaris, and this change allows suggests Solaris can call
OutputToStream anyway.

https://codereview.chromium.org/2321433003/diff/1/src/base/debug/stack_trace_...
File src/base/debug/stack_trace_posix.cc (right):

https://codereview.chromium.org/2321433003/diff/1/src/base/debug/stack_trace_...
src/base/debug/stack_trace_posix.cc:128: #if V8_LIBC_GLIBC || V8_OS_BSD ||
V8_OS_SOLARIS
Why is this change needed (and the similar changes below) needed? This doesn't
seem to change anything for Solaris?

[targos, 2016-09-12 07:33:12]

On 2016/09/07 at 11:06:22, rmcilroy wrote:
> Thanks for the CL, a couple of comments.
> 
>
https://codereview.chromium.org/2321433003/diff/1/src/base/debug/stack_trace.cc
> File src/base/debug/stack_trace.cc (right):
> 
>
https://codereview.chromium.org/2321433003/diff/1/src/base/debug/stack_trace....
> src/base/debug/stack_trace.cc:34: #if V8_LIBC_GLIBC || V8_OS_BSD ||
V8_OS_SOLARIS
> This will avoid printing on windows also which is wrong. The corresponding
change in Chromium is "#if !defined(__UCLIBC__)". Do you even need this though
(the CL mentions Solaris, and this change allows suggests Solaris can call
OutputToStream anyway.
> 
>
https://codereview.chromium.org/2321433003/diff/1/src/base/debug/stack_trace_...
> File src/base/debug/stack_trace_posix.cc (right):
> 
>
https://codereview.chromium.org/2321433003/diff/1/src/base/debug/stack_trace_...
> src/base/debug/stack_trace_posix.cc:128: #if V8_LIBC_GLIBC || V8_OS_BSD ||
V8_OS_SOLARIS
> Why is this change needed (and the similar changes below) needed? This doesn't
seem to change anything for Solaris?

This CL tries to fix two different things at the same time:
- Build on Solaris currently fails because we need to include execinfo.h and the
"V8_LIBC_GLIBC || V8_OS_BSD" condition does not include this platform. I added
"V8_OS_SOLARIS" for this reason.
- Build on Alpine Linux also fails. This distribution is based on musl libc
which does not have execinfo.h. Therefore I added the other conditions at the
same places Chromium did.

[targos, 2016-09-12 07:34:54]

https://codereview.chromium.org/2321433003/diff/1/src/base/debug/stack_trace.cc
File src/base/debug/stack_trace.cc (right):

https://codereview.chromium.org/2321433003/diff/1/src/base/debug/stack_trace....
src/base/debug/stack_trace.cc:34: #if V8_LIBC_GLIBC || V8_OS_BSD ||
V8_OS_SOLARIS
On 2016/09/07 at 11:06:22, rmcilroy wrote:
> This will avoid printing on windows also which is wrong. The corresponding
change in Chromium is "#if !defined(__UCLIBC__)". Do you even need this though
(the CL mentions Solaris, and this change allows suggests Solaris can call
OutputToStream anyway.

Would adding "|| V8_OS_WIN" be enough for Windows ?

[rmcilroy, 2016-09-12 07:51:59]

Could you split this up please. Once CL for Solaris and one for musl.

https://codereview.chromium.org/2321433003/diff/1/src/base/debug/stack_trace....
> src/base/debug/stack_trace.cc:34: #if V8_LIBC_GLIBC || V8_OS_BSD ||
> V8_OS_SOLARIS
> On 2016/09/07 at 11:06:22, rmcilroy wrote:
> > This will avoid printing on windows also which is wrong. The corresponding
> change in Chromium is "#if !defined(__UCLIBC__)". Do you even need this though
> (the CL mentions Solaris, and this change allows suggests Solaris can call
> OutputToStream anyway.
> 
> Would adding "|| V8_OS_WIN" be enough for Windows ?

I would rather you found a way to explicitly exclude musl here (like chromium
does for ulibc) rather than whitelisting platforms.

[ofrobots, 2016-09-12 12:41:34]

On 2016/09/12 07:51:59, rmcilroy wrote:
> Could you split this up please. Once CL for Solaris and one for musl.
> 
>
https://codereview.chromium.org/2321433003/diff/1/src/base/debug/stack_trace....
> > src/base/debug/stack_trace.cc:34: #if V8_LIBC_GLIBC || V8_OS_BSD ||
> > V8_OS_SOLARIS
> > On 2016/09/07 at 11:06:22, rmcilroy wrote:
> > > This will avoid printing on windows also which is wrong. The corresponding
> > change in Chromium is "#if !defined(__UCLIBC__)". Do you even need this
though
> > (the CL mentions Solaris, and this change allows suggests Solaris can call
> > OutputToStream anyway.
> > 
> > Would adding "|| V8_OS_WIN" be enough for Windows ?
> 
> I would rather you found a way to explicitly exclude musl here (like chromium
> does for ulibc) rather than whitelisting platforms.

@targos: Here's my version of your change that does this:
https://github.com/ofrobots/node/commit/5a70fadee25d67d9e3997f33e25ea8432b701a7b.

[ofrobots, 2016-09-12 21:59:31]

On 2016/09/12 12:41:34, ofrobots wrote:
> On 2016/09/12 07:51:59, rmcilroy wrote:
> > Could you split this up please. Once CL for Solaris and one for musl.
> > 
> >
>
https://codereview.chromium.org/2321433003/diff/1/src/base/debug/stack_trace....
> > > src/base/debug/stack_trace.cc:34: #if V8_LIBC_GLIBC || V8_OS_BSD ||
> > > V8_OS_SOLARIS
> > > On 2016/09/07 at 11:06:22, rmcilroy wrote:
> > > > This will avoid printing on windows also which is wrong. The
corresponding
> > > change in Chromium is "#if !defined(__UCLIBC__)". Do you even need this
> though
> > > (the CL mentions Solaris, and this change allows suggests Solaris can call
> > > OutputToStream anyway.
> > > 
> > > Would adding "|| V8_OS_WIN" be enough for Windows ?
> > 
> > I would rather you found a way to explicitly exclude musl here (like
chromium
> > does for ulibc) rather than whitelisting platforms.
> 
> @targos: Here's my version of your change that does this:
>
https://github.com/ofrobots/node/commit/5a70fadee25d67d9e3997f33e25ea8432b701a7b.

Superceded by https://codereview.chromium.org/2333023002