Fix build on Solaris and musl-based platforms

src/base/debug/stack_trace_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Slightly adapted for inclusion in V8.
 // Copyright 2016 the V8 project authors. All rights reserved.
 
 #include "src/base/debug/stack_trace.h"
 
 #include <errno.h>
 #include <fcntl.h>
 #include <signal.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <sys/param.h>
 #include <sys/stat.h>
 #include <sys/types.h>
 #include <unistd.h>
 
 #include <map>
 #include <memory>
 #include <ostream>
 #include <string>
 #include <vector>
 
-#if V8_LIBC_GLIBC || V8_OS_BSD
+#if V8_LIBC_GLIBC || V8_OS_BSD || V8_OS_SOLARIS
 #include <cxxabi.h>
 #include <execinfo.h>
 #endif
 #if V8_OS_MACOSX
 #include <AvailabilityMacros.h>
 #endif
 
 #include "src/base/build_config.h"
 #include "src/base/free_deleter.h"
 #include "src/base/logging.h"
@@ skipping 31 matching lines @@
 
 // Demangles C++ symbols in the given text. Example:
 //
 // "out/Debug/base_unittests(_ZN10StackTraceC1Ev+0x20) [0x817778c]"
 // =>
 // "out/Debug/base_unittests(StackTrace::StackTrace()+0x20) [0x817778c]"
 void DemangleSymbols(std::string* text) {
   // Note: code in this function is NOT async-signal safe (std::string uses
   // malloc internally).
 
-#if V8_LIBC_GLIBC || V8_OS_BSD
+#if V8_LIBC_GLIBC || V8_OS_BSD || V8_OS_SOLARIS
 
   std::string::size_type search_from = 0;
   while (search_from < text->size()) {
     // Look for the start of a mangled symbol, from search_from.
     std::string::size_type mangled_start =
         text->find(kMangledSymbolPrefix, search_from);
     if (mangled_start == std::string::npos) {
       break;  // Mangled symbol not found.
     }
 
@@ skipping 16 matching lines @@
       // Insert the demangled symbol.
       text->insert(mangled_start, demangled_symbol.get());
       // Next time, we'll start right after the demangled symbol we inserted.
       search_from = mangled_start + strlen(demangled_symbol.get());
     } else {
       // Failed to demangle.  Retry after the "_Z" we just found.
       search_from = mangled_start + 2;
     }
   }
 
-#endif  // V8_LIBC_GLIBC || V8_OS_BSD
+#endif  // V8_LIBC_GLIBC || V8_OS_BSD || V8_OS_SOLARIS
 }
 
 class BacktraceOutputHandler {
  public:
   virtual void HandleOutput(const char* output) = 0;
 
  protected:
   virtual ~BacktraceOutputHandler() {}
 };
 
+#if V8_LIBC_GLIBC || V8_OS_BSD || V8_OS_SOLARIS

[rmcilroy, 2016/09/07 11:06:22]

Why is this change needed (and the similar changes below) needed? This doesn't
seem to change anything for Solaris?

 void OutputPointer(void* pointer, BacktraceOutputHandler* handler) {
   // This should be more than enough to store a 64-bit number in hex:
   // 16 hex digits + 1 for null-terminator.
   char buf[17] = {'\0'};
   handler->HandleOutput("0x");
   internal::itoa_r(reinterpret_cast<intptr_t>(pointer), buf, sizeof(buf), 16,
                    12);
   handler->HandleOutput(buf);
 }
 
@@ skipping 26 matching lines @@
   }
 
   if (!printed) {
     for (size_t i = 0; i < size; ++i) {
       handler->HandleOutput(" [");
       OutputPointer(trace[i], handler);
       handler->HandleOutput("]\n");
     }
   }
 }
+#endif  // V8_LIBC_GLIBC || V8_OS_BSD || V8_OS_SOLARIS
 
 void PrintToStderr(const char* output) {
   // NOTE: This code MUST be async-signal safe (it's used by in-process
   // stack dumping signal handler). NO malloc or stdio is allowed here.
   ssize_t return_val = write(STDERR_FILENO, output, strlen(output));
   USE(return_val);
 }
 
 void StackDumpSignalHandler(int signal, siginfo_t* info, void* void_context) {
   // NOTE: This code MUST be async-signal safe.
@@ skipping 168 matching lines @@
 }
 
 void DisableSignalStackDump() {
   dump_stack_in_signal_handler = false;
 }
 
 StackTrace::StackTrace() {
   // NOTE: This code MUST be async-signal safe (it's used by in-process
   // stack dumping signal handler). NO malloc or stdio is allowed here.
 
+#if V8_LIBC_GLIBC || V8_OS_BSD || V8_OS_SOLARIS
   // Though the backtrace API man page does not list any possible negative
   // return values, we take no chance.
   count_ = static_cast<size_t>(backtrace(trace_, arraysize(trace_)));
+#else
+  count_ = 0;
+#endif
 }
 
 void StackTrace::Print() const {
   // NOTE: This code MUST be async-signal safe (it's used by in-process
   // stack dumping signal handler). NO malloc or stdio is allowed here.
 
+#if V8_LIBC_GLIBC || V8_OS_BSD || V8_OS_SOLARIS
   PrintBacktraceOutputHandler handler;
   ProcessBacktrace(trace_, count_, &handler);
+#endif
 }
 
+#if V8_LIBC_GLIBC || V8_OS_BSD || V8_OS_SOLARIS
 void StackTrace::OutputToStream(std::ostream* os) const {
   StreamBacktraceOutputHandler handler(os);
   ProcessBacktrace(trace_, count_, &handler);
 }
+#endif
 
 namespace internal {
 
 // NOTE: code from sandbox/linux/seccomp-bpf/demo.cc.
 char* itoa_r(intptr_t i, char* buf, size_t sz, int base, size_t padding) {
   // Make sure we can write at least one NUL byte.
   size_t n = 1;
   if (n > sz) return NULL;
 
   if (base < 2 || base > 16) {
@@ skipping 48 matching lines @@
     *start++ = ch;
   }
   return buf;
 }
 
 }  // namespace internal
 
 }  // namespace debug
 }  // namespace base
 }  // namespace v8