Fix backtrace for solaris and musl C based linux environments as well

Fix backtrace for solaris and musl C based linux environments as well

R=rmcilroy@chromium.org
BUG=

Committed: https://crrev.com/36e58db6be81ab3a3db9ecdddb59d8d8939f2702
Cr-Commit-Position: refs/heads/master@{#39392}

[ofrobots, 2016-09-12 22:07:47]

On 2016/09/12 21:58:28, ofrobots wrote:

This CL takes over https://codereview.chromium.org/2321433003/.  This change,
along with https://codereview.chromium.org/2292973002 and
https://codereview.chromium.org/2324453002/ are needed to integrate V8 5.4 into
Node.js for the upcoming v7.0.0 release.

From the previous CL:
> Could you split this up please. Once CL for Solaris and one for musl.

I don't think that is necessary. This CL cleans up the previous partial fixes
(for AIX and uclibc), and breaking this up by platform at this point would not
provide any clear benefits.

[rmcilroy, 2016-09-13 09:09:39]

This looks much cleaner, thanks. One suggestion, but lgtm.

https://codereview.chromium.org/2333023002/diff/1/src/base/debug/stack_trace_...
File src/base/debug/stack_trace_posix.cc (right):

https://codereview.chromium.org/2333023002/diff/1/src/base/debug/stack_trace_...
src/base/debug/stack_trace_posix.cc:387: #if HAVE_EXECINFO_H
I realize this is the way they do it in Chromium base, but could we instead have
the ifdef inside OutputToStream so that we don't need the ifdef in
stack_trace.cc.

[ofrobots, 2016-09-13 18:41:53]

The CQ bit was checked by ofrobots@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 18:41:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 19:06:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 19:06:34]

Dry run: This issue passed the CQ dry run.

[ofrobots, 2016-09-13 19:18:55]

Thanks!

https://codereview.chromium.org/2333023002/diff/1/src/base/debug/stack_trace_...
File src/base/debug/stack_trace_posix.cc (right):

https://codereview.chromium.org/2333023002/diff/1/src/base/debug/stack_trace_...
src/base/debug/stack_trace_posix.cc:387: #if HAVE_EXECINFO_H
On 2016/09/13 09:09:39, rmcilroy wrote:
> I realize this is the way they do it in Chromium base, but could we instead
have
> the ifdef inside OutputToStream so that we don't need the ifdef in
> stack_trace.cc.

Done.

[ofrobots, 2016-09-13 19:19:05]

The CQ bit was checked by ofrobots@google.com

[ofrobots, 2016-09-13 19:19:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2333023002/#ps20001
(title: "address code review comments")

[commit-bot: I haz the power, 2016-09-13 19:19:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 19:21:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-13 19:22:31]

Description was changed from

==========
Fix backtrace for solaris and musl C based linux environments as well

R=rmcilroy@chromium.org
BUG=
==========

to

==========
Fix backtrace for solaris and musl C based linux environments as well

R=rmcilroy@chromium.org
BUG=

Committed: https://crrev.com/36e58db6be81ab3a3db9ecdddb59d8d8939f2702
Cr-Commit-Position: refs/heads/master@{#39392}
==========

[commit-bot: I haz the power, 2016-09-13 19:22:31]

Patchset 2 (id:??) landed as
https://crrev.com/36e58db6be81ab3a3db9ecdddb59d8d8939f2702
Cr-Commit-Position: refs/heads/master@{#39392}