binding: Let indexed interceptor falls through to named interceptor.

binding: Let indexed interceptor falls through to named interceptor.

V8's named interceptor never traps |0| of type number nor |"0"|
of type string.  Both of |0| and |"0"| trigger indexed interceptor.

In order for named properties to capture property keys such as 0
or "0", we have to first trap them at indexed interceptor, and
then fall through to an named property handler.

If an interface supports indexed properties, we don't need this
fallback mechanism.  If an interface only supports named
properties, let 0 or "0" fall through to an named property
handler.

BUG=229750
Committed: https://crrev.com/4808123c1e7ee6e9ebce4d5d803cf9073b96d72b
Cr-Commit-Position: refs/heads/master@{#418495}

[Yuki, 2016-09-08 15:08:53]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 15:09:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2016-09-08 15:22:37]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 15:22:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2016-09-08 15:29:08]

Description was changed from

==========
binding: Let indexed interceptor falls through to named interceptor.

BUG=229750
==========

to

==========
binding: Let indexed interceptor falls through to named interceptor.

V8's named interceptor never traps |0| of type number nor |"0"|
of type string.  Both of |0| and |"0"| trigger indexed interceptor.

In order for named properties to capture property keys such as 0
or "0", we have to first trap them at indexed interceptor, and
then fall through to an named property handler.

If an interface supports indexed properties, we don't need this
fallback mechanism.  If an interface only supports named
properties, let 0 or "0" fall through to an named property
handler.

BUG=229750
==========

[Yuki, 2016-09-08 15:31:24]

yukishiino@chromium.org changed reviewers:
+ haraken@chromium.org

[Yuki, 2016-09-08 15:31:25]

Could you review this CL?

[commit-bot: I haz the power, 2016-09-08 16:31:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 16:31:58]

Dry run: Exceeded global retry quota

[haraken, 2016-09-09 00:46:09]

LGTM assuming this doesn't change any web-exposed behavior.

[peria, 2016-09-09 02:44:50]

peria@chromium.org changed reviewers:
+ peria@chromium.org

[peria, 2016-09-09 02:44:51]

LGTM

https://codereview.chromium.org/2321073002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/2321073002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/templates/interface.cpp:391: communicate
property attributes. #}
TODO

[Yuki, 2016-09-13 06:58:30]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 06:58:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2016-09-13 08:40:28]

The CQ bit was checked by yukishiino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 08:40:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yuki, 2016-09-13 09:02:27]

yukishiino@chromium.org changed reviewers:
+ tkent@chromium.org

[Yuki, 2016-09-13 09:02:28]

It turned out that this CL removes @iterator from Storage.
Per spec[1], we shouldn't have @iterator in Storage.

Could you guys take another look?

tkent@: Could you review as an owner of global-interface-listing?


[1] https://html.spec.whatwg.org/multipage/webstorage.html#the-storage-interface

[peria, 2016-09-13 09:14:43]

lgtm

[tkent, 2016-09-13 09:15:31]

> tkent@: Could you review as an owner of global-interface-listing?

Do you have any data of usage of @@iterator on Storage?

[Yuki, 2016-09-13 10:11:05]

On 2016/09/13 09:15:31, tkent wrote:
> > tkent@: Could you review as an owner of global-interface-listing?
> 
> Do you have any data of usage of @@iterator on Storage?

No, I don't have.  I don't think people write localStorage[Symbol.iterator].
Without @@iterator, you can still write
    for (e in localStorage) { ... }

[commit-bot: I haz the power, 2016-09-13 10:20:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 10:20:28]

Dry run: This issue passed the CQ dry run.

[Yuki, 2016-09-13 12:49:21]

On 2016/09/13 10:11:05, Yuki wrote:
> On 2016/09/13 09:15:31, tkent wrote:
> > > tkent@: Could you review as an owner of global-interface-listing?
> > 
> > Do you have any data of usage of @@iterator on Storage?
> 
> No, I don't have.  I don't think people write localStorage[Symbol.iterator].
> Without @@iterator, you can still write
>     for (e in localStorage) { ... }

Plus, on FF, localStorage[Symbol.iterator] returns undefined.

[tkent, 2016-09-13 23:25:17]

Ah, I understand the current behavior of localStorage[Symbol.iterator] is
completely useless. It must be safe to remove it. lgtm.

[Yuki, 2016-09-14 05:45:21]

The CQ bit was checked by yukishiino@chromium.org

[Yuki, 2016-09-14 05:45:21]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2321073002/#ps80001
(title: "Updated global-interface-listing expectations.")

[commit-bot: I haz the power, 2016-09-14 05:45:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 05:51:45]

Description was changed from

==========
binding: Let indexed interceptor falls through to named interceptor.

V8's named interceptor never traps |0| of type number nor |"0"|
of type string.  Both of |0| and |"0"| trigger indexed interceptor.

In order for named properties to capture property keys such as 0
or "0", we have to first trap them at indexed interceptor, and
then fall through to an named property handler.

If an interface supports indexed properties, we don't need this
fallback mechanism.  If an interface only supports named
properties, let 0 or "0" fall through to an named property
handler.

BUG=229750
==========

to

==========
binding: Let indexed interceptor falls through to named interceptor.

V8's named interceptor never traps |0| of type number nor |"0"|
of type string.  Both of |0| and |"0"| trigger indexed interceptor.

In order for named properties to capture property keys such as 0
or "0", we have to first trap them at indexed interceptor, and
then fall through to an named property handler.

If an interface supports indexed properties, we don't need this
fallback mechanism.  If an interface only supports named
properties, let 0 or "0" fall through to an named property
handler.

BUG=229750
==========

[commit-bot: I haz the power, 2016-09-14 05:51:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-14 05:54:27]

Description was changed from

==========
binding: Let indexed interceptor falls through to named interceptor.

V8's named interceptor never traps |0| of type number nor |"0"|
of type string.  Both of |0| and |"0"| trigger indexed interceptor.

In order for named properties to capture property keys such as 0
or "0", we have to first trap them at indexed interceptor, and
then fall through to an named property handler.

If an interface supports indexed properties, we don't need this
fallback mechanism.  If an interface only supports named
properties, let 0 or "0" fall through to an named property
handler.

BUG=229750
==========

to

==========
binding: Let indexed interceptor falls through to named interceptor.

V8's named interceptor never traps |0| of type number nor |"0"|
of type string.  Both of |0| and |"0"| trigger indexed interceptor.

In order for named properties to capture property keys such as 0
or "0", we have to first trap them at indexed interceptor, and
then fall through to an named property handler.

If an interface supports indexed properties, we don't need this
fallback mechanism.  If an interface only supports named
properties, let 0 or "0" fall through to an named property
handler.

BUG=229750

Committed: https://crrev.com/4808123c1e7ee6e9ebce4d5d803cf9073b96d72b
Cr-Commit-Position: refs/heads/master@{#418495}
==========

[commit-bot: I haz the power, 2016-09-14 05:54:28]

Patchset 5 (id:??) landed as
https://crrev.com/4808123c1e7ee6e9ebce4d5d803cf9073b96d72b
Cr-Commit-Position: refs/heads/master@{#418495}