Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp

Issue 2321073002: binding: Let indexed interceptor falls through to named interceptor. (Closed)
Patch Set: Updated global-interface-listing expectations. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp
index 84f6251ebdcd836df57d2ef1807ff8b353010677..ce02d2f21100d8cbb53287cf06e89d40534f51d3 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface3.cpp
@@ -196,47 +196,40 @@ static void iteratorMethodCallback(const v8::FunctionCallbackInfo<v8::Value>& in
TestInterface3V8Internal::iteratorMethod(info);
}
-void indexedPropertyGetterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info)
-{
- V8TestInterface3::indexedPropertyGetterCustom(index, info);
-}
-
-void indexedPropertySetterCallback(uint32_t index, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<v8::Value>& info)
-{
- V8TestInterface3::indexedPropertySetterCustom(index, v8Value, info);
-}
-
-void indexedPropertyDeleterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Boolean>& info)
-{
- V8TestInterface3::indexedPropertyDeleterCustom(index, info);
-}
-
void namedPropertyGetterCallback(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Value>& info)
{
if (!name->IsString())
return;
- V8TestInterface3::namedPropertyGetterCustom(name, info);
+ const AtomicString& propertyName = toCoreAtomicString(name.As<v8::String>());
+
+ V8TestInterface3::namedPropertyGetterCustom(propertyName, info);
}
void namedPropertySetterCallback(v8::Local<v8::Name> name, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<v8::Value>& info)
{
if (!name->IsString())
return;
- V8TestInterface3::namedPropertySetterCustom(name, v8Value, info);
+ const AtomicString& propertyName = toCoreAtomicString(name.As<v8::String>());
+
+ V8TestInterface3::namedPropertySetterCustom(propertyName, v8Value, info);
}
-void namedPropertyQueryCallback(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Integer>& info)
+void namedPropertyDeleterCallback(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Boolean>& info)
{
if (!name->IsString())
return;
- V8TestInterface3::namedPropertyQueryCustom(name, info);
+ const AtomicString& propertyName = toCoreAtomicString(name.As<v8::String>());
+
+ V8TestInterface3::namedPropertyDeleterCustom(propertyName, info);
}
-void namedPropertyDeleterCallback(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Boolean>& info)
+void namedPropertyQueryCallback(v8::Local<v8::Name> name, const v8::PropertyCallbackInfo<v8::Integer>& info)
{
if (!name->IsString())
return;
- V8TestInterface3::namedPropertyDeleterCustom(name, info);
+ const AtomicString& propertyName = toCoreAtomicString(name.As<v8::String>());
+
+ V8TestInterface3::namedPropertyQueryCustom(propertyName, info);
}
void namedPropertyEnumeratorCallback(const v8::PropertyCallbackInfo<v8::Array>& info)
@@ -244,6 +237,21 @@ void namedPropertyEnumeratorCallback(const v8::PropertyCallbackInfo<v8::Array>&
V8TestInterface3::namedPropertyEnumeratorCustom(info);
}
+void indexedPropertyGetterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info)
+{
+ V8TestInterface3::indexedPropertyGetterCustom(index, info);
+}
+
+void indexedPropertySetterCallback(uint32_t index, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<v8::Value>& info)
+{
+ V8TestInterface3::indexedPropertySetterCustom(index, v8Value, info);
+}
+
+void indexedPropertyDeleterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Boolean>& info)
+{
+ V8TestInterface3::indexedPropertyDeleterCustom(index, info);
+}
+
} // namespace TestInterface3V8Internal
void V8TestInterface3::visitDOMWrapper(v8::Isolate* isolate, ScriptWrappable* scriptWrappable, const v8::Persistent<v8::Object>& wrapper)

Powered by Google App Engine
This is Rietveld 408576698