Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp

Issue 2321073002: binding: Let indexed interceptor falls through to named interceptor. (Closed)
Patch Set: Updated global-interface-listing expectations. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% filter format_blink_cpp_source_code %} 1 {% filter format_blink_cpp_source_code %}
2 2
3 {% include 'copyright_block.txt' %} 3 {% include 'copyright_block.txt' %}
4 #include "{{v8_class_or_partial}}.h" 4 #include "{{v8_class_or_partial}}.h"
5 5
6 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %} 6 {% for filename in cpp_includes if filename != '%s.h' % cpp_class_or_partial %}
7 #include "{{filename}}" 7 #include "{{filename}}"
8 {% endfor %} 8 {% endfor %}
9 9
10 namespace blink { 10 namespace blink {
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 {{method_callback(iterator_method)}} 183 {{method_callback(iterator_method)}}
184 {% endif %} 184 {% endif %}
185 {% block origin_safe_method_setter %}{% endblock %} 185 {% block origin_safe_method_setter %}{% endblock %}
186 {# Constructors #} 186 {# Constructors #}
187 {% for constructor in constructors %} 187 {% for constructor in constructors %}
188 {{generate_constructor(constructor)}} 188 {{generate_constructor(constructor)}}
189 {% endfor %} 189 {% endfor %}
190 {% block overloaded_constructor %}{% endblock %} 190 {% block overloaded_constructor %}{% endblock %}
191 {% block event_constructor %}{% endblock %} 191 {% block event_constructor %}{% endblock %}
192 {# Special operations (methods) #} 192 {# Special operations (methods) #}
193 {% block named_property_getter %}{% endblock %}
194 {% block named_property_getter_callback %}{% endblock %}
195 {% block named_property_setter %}{% endblock %}
196 {% block named_property_setter_callback %}{% endblock %}
197 {% block named_property_deleter %}{% endblock %}
198 {% block named_property_deleter_callback %}{% endblock %}
199 {% block named_property_query %}{% endblock %}
200 {% block named_property_query_callback %}{% endblock %}
201 {% block named_property_enumerator %}{% endblock %}
202 {% block named_property_enumerator_callback %}{% endblock %}
193 {% block indexed_property_getter %}{% endblock %} 203 {% block indexed_property_getter %}{% endblock %}
194 {% block indexed_property_getter_callback %}{% endblock %} 204 {% block indexed_property_getter_callback %}{% endblock %}
195 {% block indexed_property_setter %}{% endblock %} 205 {% block indexed_property_setter %}{% endblock %}
196 {% block indexed_property_setter_callback %}{% endblock %} 206 {% block indexed_property_setter_callback %}{% endblock %}
197 {% block indexed_property_deleter %}{% endblock %} 207 {% block indexed_property_deleter %}{% endblock %}
198 {% block indexed_property_deleter_callback %}{% endblock %} 208 {% block indexed_property_deleter_callback %}{% endblock %}
199 {% block named_property_getter %}{% endblock %}
200 {% block named_property_getter_callback %}{% endblock %}
201 {% block named_property_setter %}{% endblock %}
202 {% block named_property_setter_callback %}{% endblock %}
203 {% block named_property_query %}{% endblock %}
204 {% block named_property_query_callback %}{% endblock %}
205 {% block named_property_deleter %}{% endblock %}
206 {% block named_property_deleter_callback %}{% endblock %}
207 {% block named_property_enumerator %}{% endblock %}
208 {% block named_property_enumerator_callback %}{% endblock %}
209 } // namespace {{cpp_class_or_partial}}V8Internal 209 } // namespace {{cpp_class_or_partial}}V8Internal
210 210
211 {% block visit_dom_wrapper %}{% endblock %} 211 {% block visit_dom_wrapper %}{% endblock %}
212 {##############################################################################} 212 {##############################################################################}
213 {% block install_attributes %} 213 {% block install_attributes %}
214 {% from 'attributes.cpp' import attribute_configuration with context %} 214 {% from 'attributes.cpp' import attribute_configuration with context %}
215 {% if attributes | has_attribute_configuration %} 215 {% if attributes | has_attribute_configuration %}
216 // Suppress warning: global constructors, because AttributeConfiguration is triv ial 216 // Suppress warning: global constructors, because AttributeConfiguration is triv ial
217 // and does not depend on another global objects. 217 // and does not depend on another global objects.
218 #if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG) 218 #if defined(COMPONENT_BUILD) && defined(WIN32) && COMPILER(CLANG)
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
333 V8DOMConfiguration::installAttribute(isolate, world, instanceTemplate, p rototypeTemplate, attribute{{attribute.name}}Configuration); 333 V8DOMConfiguration::installAttribute(isolate, world, instanceTemplate, p rototypeTemplate, attribute{{attribute.name}}Configuration);
334 {% else %} 334 {% else %}
335 const V8DOMConfiguration::AccessorConfiguration accessor{{attribute.name }}Configuration = \ 335 const V8DOMConfiguration::AccessorConfiguration accessor{{attribute.name }}Configuration = \
336 {{attribute_configuration(attribute)}}; 336 {{attribute_configuration(attribute)}};
337 V8DOMConfiguration::installAccessor(isolate, world, instanceTemplate, pr ototypeTemplate, interfaceTemplate, signature, accessor{{attribute.name}}Configu ration); 337 V8DOMConfiguration::installAccessor(isolate, world, instanceTemplate, pr ototypeTemplate, interfaceTemplate, signature, accessor{{attribute.name}}Configu ration);
338 {% endif %} 338 {% endif %}
339 {% endfor %} 339 {% endfor %}
340 } 340 }
341 {% endfor %} 341 {% endfor %}
342 342
343 {%- if indexed_property_getter and not is_partial %}{{newline}} 343 {% if (indexed_property_getter or named_property_getter) and not is_partial %}
344 // Indexed properties 344 // Indexed properties
345 {{install_indexed_property_handler('instanceTemplate') | indent}} 345 {{install_indexed_property_handler('instanceTemplate') | indent}}
346 {% endif %} 346 {% endif %}
347 {% if named_property_getter and not is_partial and not has_named_properties_ object %} 347 {% if named_property_getter and not is_partial and not has_named_properties_ object %}
348 // Named properties 348 // Named properties
349 {{install_named_property_handler('instanceTemplate') | indent}} 349 {{install_named_property_handler('instanceTemplate') | indent}}
350 {% endif %} 350 {% endif %}
351 351
352 {%- if iterator_method %}{{newline}} 352 {%- if iterator_method %}{{newline}}
353 {% filter exposed(iterator_method.exposed_test) %} 353 {% filter exposed(iterator_method.exposed_test) %}
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 {% for attribute in attributes if attribute.is_implemented_in_private_script %} 457 {% for attribute in attributes if attribute.is_implemented_in_private_script %}
458 {{attribute_getter_implemented_in_private_script(attribute)}} 458 {{attribute_getter_implemented_in_private_script(attribute)}}
459 {% if attribute.has_setter %} 459 {% if attribute.has_setter %}
460 {{attribute_setter_implemented_in_private_script(attribute)}} 460 {{attribute_setter_implemented_in_private_script(attribute)}}
461 {% endif %} 461 {% endif %}
462 {% endfor %} 462 {% endfor %}
463 {% block partial_interface %}{% endblock %} 463 {% block partial_interface %}{% endblock %}
464 } // namespace blink 464 } // namespace blink
465 465
466 {% endfilter %}{# format_blink_cpp_source_code #} 466 {% endfilter %}{# format_blink_cpp_source_code #}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698