Issue 232083002: Fix PATH searching for Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 232083002: Fix PATH searching for Windows. (Closed)

Created:
6 years, 8 months ago by szager1

Modified:
6 years, 8 months ago

Reviewers:
iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Fix PATH searching for Windows. I am TBR-ing everything today. TBR=agable@chromium.org,hinoka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262831

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	git_cache.py	View		1 chunk	+5 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

iannucci

6 years, 8 months ago (2014-04-10 16:50:48 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/232083002/diff/1/git_cache.py
File git_cache.py (right):

https://codereview.chromium.org/232083002/diff/1/git_cache.py#newcode161
git_cache.py:161: if os.path.isfile(alt_target) and os.access(target, os.X_OK):
wouldn't os.access(... X_OK) always return True on windows?

Expand Messages | Collapse Messages