git_cache.py - Issue 232083002: Fix PATH searching for Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cache.py

Issue 232083002: Fix PATH searching for Windows. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: git_cache.py

diff --git a/git_cache.py b/git_cache.py

index b60073e972b1aa84e0eb091230df8e4a068ddf04..66f5f8660d2fcb1ab884b4d903f0c4919ad29317 100755

--- a/git_cache.py

+++ b/git_cache.py

@@ -155,6 +155,11 @@ class Mirror(object):

target = os.path.abspath(os.path.expanduser(target))

if os.path.isfile(target) and os.access(target, os.X_OK):

return target

+ if sys.platform.startswith('win'):

+ for suffix in ('.bat', '.cmd', '.exe'):

+ alt_target = target + suffix

+ if os.path.isfile(alt_target) and os.access(target, os.X_OK):

iannucci 2014/04/10 16:50:48 wouldn't os.access(... X_OK) always return True on

+ return alt_target

return None

@classmethod

« no previous file with comments | « no previous file | no next file » | no next file with comments »