Fix PATH searching for Windows.

git_cache.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """A git command for managing a local cache of git repositories."""
 
 from __future__ import print_function
 import errno
 import logging
@@ skipping 137 matching lines @@
   def FindExecutable(executable):
     """This mimics the "which" utility."""
     path_folders = os.environ.get('PATH').split(os.pathsep)
 
     for path_folder in path_folders:
       target = os.path.join(path_folder, executable)
       # Just incase we have some ~/blah paths.
       target = os.path.abspath(os.path.expanduser(target))
       if os.path.isfile(target) and os.access(target, os.X_OK):
         return target
+      if sys.platform.startswith('win'):
+        for suffix in ('.bat', '.cmd', '.exe'):
+          alt_target = target + suffix
+          if os.path.isfile(alt_target) and os.access(target, os.X_OK):

[iannucci, 2014/04/10 16:50:48]

wouldn't os.access(... X_OK) always return True on windows?

+            return alt_target
     return None
 
   @classmethod
   def SetCachePath(cls, cachepath):
     setattr(cls, 'cachepath', cachepath)
 
   @classmethod
   def GetCachePath(cls):
     if not hasattr(cls, 'cachepath'):
       try:
@@ skipping 317 matching lines @@
     return options, args
 
 
 def main(argv):
   dispatcher = subcommand.CommandDispatcher(__name__)
   return dispatcher.execute(OptionParser(), argv)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))