[deoptimizer] Clear context before NotifyDeoptimized.

[deoptimizer] Clear context before NotifyDeoptimized.

This clears the context register by setting it to Smi(0) before calling
the Runtime::kNotifyDeoptimized helper. The deoptimizer must be able to
materialize all heap objects without any context available. The context
itself might be dematerialized.

With this change we make sure that invariant is maintained even without
escape analysis kicking in. We also satisfy the check that the context
register is either Smi(0) or a valid context. It might have been the
special {arguments_marker} in this particular case.

R=bmeurer@chromium.org
BUG=chromium:644245
Committed: https://crrev.com/96164b74f1fa5a73a9632eaae9179813cd6a0a92
Cr-Commit-Position: refs/heads/master@{#39267}

[Michael Starzinger, 2016-09-07 14:56:07]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 14:56:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 15:19:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 15:19:05]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-09-07 15:29:01]

Description was changed from

==========
[deoptimizer] Clear context before NotifyDeoptimized.

This clears the context register by setting it to Smi(0) before calling
the Runtime::kNotifyDeoptimized helper. The deoptimizer must be able to
materialize all heap objects without any context available. The context
itself might be dematerialized.

With this change we make sure that invariant is maintained even without
escape analysis kicking in. We also satisfy the check that the context
register is either Smi(0) or a valid context. It might have been the
special {arguments_marker} in this particular case.

R=
BUG=chromium:644245
==========

to

==========
[deoptimizer] Clear context before NotifyDeoptimized.

This clears the context register by setting it to Smi(0) before calling
the Runtime::kNotifyDeoptimized helper. The deoptimizer must be able to
materialize all heap objects without any context available. The context
itself might be dematerialized.

With this change we make sure that invariant is maintained even without
escape analysis kicking in. We also satisfy the check that the context
register is either Smi(0) or a valid context. It might have been the
special {arguments_marker} in this particular case.

R=bmeurer@chromium.org
BUG=chromium:644245
==========

[Michael Starzinger, 2016-09-07 15:29:01]

mstarzinger@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-09-07 16:58:00]

Very nice, I like this a lot. LGTM.

https://codereview.chromium.org/2320673002/diff/1/src/runtime/runtime-compile...
File src/runtime/runtime-compiler.cc (right):

https://codereview.chromium.org/2320673002/diff/1/src/runtime/runtime-compile...
src/runtime/runtime-compiler.cc:175: DCHECK(isolate->context() == nullptr);
Nit: DCHECK_NULL

[Michael Starzinger, 2016-09-08 08:46:42]

Thanks! Addressed comments. Landing.

https://codereview.chromium.org/2320673002/diff/1/src/runtime/runtime-compile...
File src/runtime/runtime-compiler.cc (right):

https://codereview.chromium.org/2320673002/diff/1/src/runtime/runtime-compile...
src/runtime/runtime-compiler.cc:175: DCHECK(isolate->context() == nullptr);
On 2016/09/07 16:58:00, Benedikt Meurer wrote:
> Nit: DCHECK_NULL

Done.

[Michael Starzinger, 2016-09-08 08:46:53]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 08:47:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 09:30:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 09:30:16]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-09-08 09:49:35]

The CQ bit was checked by mstarzinger@chromium.org

[Michael Starzinger, 2016-09-08 09:49:35]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2320673002/#ps20001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2016-09-08 09:49:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 09:51:38]

Description was changed from

==========
[deoptimizer] Clear context before NotifyDeoptimized.

This clears the context register by setting it to Smi(0) before calling
the Runtime::kNotifyDeoptimized helper. The deoptimizer must be able to
materialize all heap objects without any context available. The context
itself might be dematerialized.

With this change we make sure that invariant is maintained even without
escape analysis kicking in. We also satisfy the check that the context
register is either Smi(0) or a valid context. It might have been the
special {arguments_marker} in this particular case.

R=bmeurer@chromium.org
BUG=chromium:644245
==========

to

==========
[deoptimizer] Clear context before NotifyDeoptimized.

This clears the context register by setting it to Smi(0) before calling
the Runtime::kNotifyDeoptimized helper. The deoptimizer must be able to
materialize all heap objects without any context available. The context
itself might be dematerialized.

With this change we make sure that invariant is maintained even without
escape analysis kicking in. We also satisfy the check that the context
register is either Smi(0) or a valid context. It might have been the
special {arguments_marker} in this particular case.

R=bmeurer@chromium.org
BUG=chromium:644245
==========

[commit-bot: I haz the power, 2016-09-08 09:51:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-08 09:52:16]

Description was changed from

==========
[deoptimizer] Clear context before NotifyDeoptimized.

This clears the context register by setting it to Smi(0) before calling
the Runtime::kNotifyDeoptimized helper. The deoptimizer must be able to
materialize all heap objects without any context available. The context
itself might be dematerialized.

With this change we make sure that invariant is maintained even without
escape analysis kicking in. We also satisfy the check that the context
register is either Smi(0) or a valid context. It might have been the
special {arguments_marker} in this particular case.

R=bmeurer@chromium.org
BUG=chromium:644245
==========

to

==========
[deoptimizer] Clear context before NotifyDeoptimized.

This clears the context register by setting it to Smi(0) before calling
the Runtime::kNotifyDeoptimized helper. The deoptimizer must be able to
materialize all heap objects without any context available. The context
itself might be dematerialized.

With this change we make sure that invariant is maintained even without
escape analysis kicking in. We also satisfy the check that the context
register is either Smi(0) or a valid context. It might have been the
special {arguments_marker} in this particular case.

R=bmeurer@chromium.org
BUG=chromium:644245

Committed: https://crrev.com/96164b74f1fa5a73a9632eaae9179813cd6a0a92
Cr-Commit-Position: refs/heads/master@{#39267}
==========

[commit-bot: I haz the power, 2016-09-08 09:52:17]

Patchset 2 (id:??) landed as
https://crrev.com/96164b74f1fa5a73a9632eaae9179813cd6a0a92
Cr-Commit-Position: refs/heads/master@{#39267}