Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 3 months ago by Michael Starzinger Modified:
4 years, 3 months ago Reviewers:
rmcilroy CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[deoptimizer] Support virtual context in interpreted frame.
This adds support for dematerialized context values as part of an
interpreted frame (similar to an FCG frame). Both frame translations
should be kept in sync as much as possible.
R=rmcilroy@chromium.org
BUG=chromium:644728
Committed: https://crrev.com/279bc5096badf7a9f4134d433d8fd70d6d4a6f9c
Cr-Commit-Position: refs/heads/master@{#39256}
Patch Set 1 #
Created: 4 years, 3 months ago
Dependent Patchsets: Messages
Total messages: 15 (10 generated)
The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [deoptimizer] Support virtual context in interpreted frame. This add support for dematerialized context values as part of an interpreted frame (similar to an FCG frame). Both frame translations should be kept in sync as much as possible. R= BUG=chromium:644728 ========== to ========== [deoptimizer] Support virtual context in interpreted frame. This add support for dematerialized context values as part of an interpreted frame (similar to an FCG frame). Both frame translations should be kept in sync as much as possible. R=rmcilroy@chromium.org BUG=chromium:644728 ==========
mstarzinger@chromium.org changed reviewers: + rmcilroy@chromium.org
Note that I cannot (yet) add a regression test, because once this is fixed it fails similar to issue chromium:644245. But this will be covered by the regression test of said issue due to our test variants once I address that.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by mstarzinger@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [deoptimizer] Support virtual context in interpreted frame. This add support for dematerialized context values as part of an interpreted frame (similar to an FCG frame). Both frame translations should be kept in sync as much as possible. R=rmcilroy@chromium.org BUG=chromium:644728 ========== to ========== [deoptimizer] Support virtual context in interpreted frame. This adds support for dematerialized context values as part of an interpreted frame (similar to an FCG frame). Both frame translations should be kept in sync as much as possible. R=rmcilroy@chromium.org BUG=chromium:644728 ==========
Message was sent while issue was closed.
Description was changed from ========== [deoptimizer] Support virtual context in interpreted frame. This adds support for dematerialized context values as part of an interpreted frame (similar to an FCG frame). Both frame translations should be kept in sync as much as possible. R=rmcilroy@chromium.org BUG=chromium:644728 ========== to ========== [deoptimizer] Support virtual context in interpreted frame. This adds support for dematerialized context values as part of an interpreted frame (similar to an FCG frame). Both frame translations should be kept in sync as much as possible. R=rmcilroy@chromium.org BUG=chromium:644728 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [deoptimizer] Support virtual context in interpreted frame. This adds support for dematerialized context values as part of an interpreted frame (similar to an FCG frame). Both frame translations should be kept in sync as much as possible. R=rmcilroy@chromium.org BUG=chromium:644728 ========== to ========== [deoptimizer] Support virtual context in interpreted frame. This adds support for dematerialized context values as part of an interpreted frame (similar to an FCG frame). Both frame translations should be kept in sync as much as possible. R=rmcilroy@chromium.org BUG=chromium:644728 Committed: https://crrev.com/279bc5096badf7a9f4134d433d8fd70d6d4a6f9c Cr-Commit-Position: refs/heads/master@{#39256} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/279bc5096badf7a9f4134d433d8fd70d6d4a6f9c Cr-Commit-Position: refs/heads/master@{#39256} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
