Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2313343002: [deoptimizer] Support virtual context in interpreted frame. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
rmcilroy
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Support virtual context in interpreted frame. This adds support for dematerialized context values as part of an interpreted frame (similar to an FCG frame). Both frame translations should be kept in sync as much as possible. R=rmcilroy@chromium.org BUG=chromium:644728 Committed: https://crrev.com/279bc5096badf7a9f4134d433d8fd70d6d4a6f9c Cr-Commit-Position: refs/heads/master@{#39256}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M src/deoptimizer.cc View 3 chunks +12 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
Michael Starzinger
Note that I cannot (yet) add a regression test, because once this is fixed it ...
4 years, 3 months ago (2016-09-07 13:57:28 UTC) #5
rmcilroy
lgtm
4 years, 3 months ago (2016-09-07 15:07:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313343002/1
4 years, 3 months ago (2016-09-07 15:59:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 16:02:07 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 16:02:25 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/279bc5096badf7a9f4134d433d8fd70d6d4a6f9c
Cr-Commit-Position: refs/heads/master@{#39256}

Powered by Google App Engine
This is Rietveld 408576698