Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 2323713002: [deoptimizer] Materialize JSArray objects without context. (Closed)

Created:
4 years, 3 months ago by Michael Starzinger
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Materialize JSArray objects without context. This fixes the materialization of JSArray objects to not rely on a context being available. The context has been cleared because it might be de-materiallized itself. R=bmeurer@chromium.org BUG=chromium:644245 Committed: https://crrev.com/517a54286d4dd8c23dce0e19306c199a1930266c Cr-Commit-Position: refs/heads/master@{#39274}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/deoptimizer.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Michael Starzinger
4 years, 3 months ago (2016-09-08 10:30:23 UTC) #3
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-08 10:44:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323713002/1
4 years, 3 months ago (2016-09-08 11:35:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 11:37:49 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 11:38:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/517a54286d4dd8c23dce0e19306c199a1930266c
Cr-Commit-Position: refs/heads/master@{#39274}

Powered by Google App Engine
This is Rietveld 408576698