LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py - Issue 23201008: Active WebSocket should send closing handshake to server on page navigation or page close

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py

Issue 23201008: Active WebSocket should send closing handshake to server on page navigation or page close (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py

diff --git a/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py b/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py

index 4c13115b2439bfb76d31286adce9ec65e1046292..65e455e4e0dbddfbd6265ddfdc59f4023778b0d6 100644

--- a/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py

+++ b/LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py

@@ -48,7 +48,6 @@ def web_socket_transfer_data(request):

# notify to client that socketName is received by server.

msgutil.send_message(request, socketName)

msgutil.receive_message(request) # wait, and exception by close.

- socketName = socketName + ': receive next message'

tyoshino (SeeGerritForStatus) 2013/08/20 03:07:07 looks ok to remove this. instead of this line, cou

finally:

# request is closed. notify this socketName to other web sockets.

del connections[request]

« no previous file with comments | « no previous file | Source/modules/websockets/WebSocket.cpp » ('j') | Source/modules/websockets/WebSocket.cpp » ('J')