Source/modules/websockets/WebSocket.cpp - Issue 23201008: Active WebSocket should send closing handshake to server on page navigation or page close

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/WebSocket.cpp

Issue 23201008: Active WebSocket should send closing handshake to server on page navigation or page close (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py ('K') | « LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/websockets/WebSocket.cpp

diff --git a/Source/modules/websockets/WebSocket.cpp b/Source/modules/websockets/WebSocket.cpp

index 9016a538928649449bae969c589595524b5a0b9d..550312e1cf2432256378fe8ef5c43e3f70f260c0 100644

--- a/Source/modules/websockets/WebSocket.cpp

+++ b/Source/modules/websockets/WebSocket.cpp

@@ -505,6 +505,7 @@ void WebSocket::stop()

return;

}

if (m_channel) {

+ m_channel->close(WebSocketChannel::CloseEventCodeGoingAway, "");

tyoshino (SeeGerritForStatus) 2013/08/20 03:07:07 let me correct. please use String() for consistenc

m_channel->disconnect();

m_channel = 0;

}