LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py - Issue 23201008: Active WebSocket should send closing handshake to server on page navigation or page close

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/websocket/tests/hybi/close-on-unload_wsh.py

Issue 23201008: Active WebSocket should send closing handshake to server on page navigation or page close (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2009, Google Inc.	1 # Copyright 2009, Google Inc.

2 # All rights reserved.	2 # All rights reserved.

3 #	3 #

4 # Redistribution and use in source and binary forms, with or without	4 # Redistribution and use in source and binary forms, with or without

5 # modification, are permitted provided that the following conditions are	5 # modification, are permitted provided that the following conditions are

6 # met:	6 # met:

7 #	7 #

8 # * Redistributions of source code must retain the above copyright	8 # * Redistributions of source code must retain the above copyright

9 # notice, this list of conditions and the following disclaimer.	9 # notice, this list of conditions and the following disclaimer.

10 # * Redistributions in binary form must reproduce the above	10 # * Redistributions in binary form must reproduce the above

(...skipping 30 matching lines...) Expand all Loading...
41	41

42 def web_socket_transfer_data(request):	42 def web_socket_transfer_data(request):

43 global connections	43 global connections

44 connections[request] = True	44 connections[request] = True

45 socketName = None	45 socketName = None

46 try:	46 try:

47 socketName = msgutil.receive_message(request)	47 socketName = msgutil.receive_message(request)

48 # notify to client that socketName is received by server.	48 # notify to client that socketName is received by server.

49 msgutil.send_message(request, socketName)	49 msgutil.send_message(request, socketName)

50 msgutil.receive_message(request) # wait, and exception by close.	50 msgutil.receive_message(request) # wait, and exception by close.

51 socketName = socketName + ': receive next message'
tyoshino (SeeGerritForStatus) 2013/08/20 03:07:07 looks ok to remove this. instead of this line, cou looks ok to remove this. instead of this line, could you please get the received close code using request.ws_close_code and append it to socketName so that we can check if the right code was sent?
52 finally:	51 finally:

53 # request is closed. notify this socketName to other web sockets.	52 # request is closed. notify this socketName to other web sockets.

54 del connections[request]	53 del connections[request]

55 for ws in connections.keys():	54 for ws in connections.keys():

56 msgutil.send_message(ws, socketName)	55 msgutil.send_message(ws, socketName)

OLD	NEW

« no previous file with comments | « no previous file | Source/modules/websockets/WebSocket.cpp » ('j') | Source/modules/websockets/WebSocket.cpp » ('J')