Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2319243002: [stubs] Fixing loads/stores from arrays by int32 offsets/indices. Step 3. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Fixing loads/stores from arrays by int32 offsets/indices. Step 3. Committed: https://crrev.com/4ef7e3e7c710a1bef7ea21657113f3035111624b Cr-Commit-Position: refs/heads/master@{#39276}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixing redness #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -160 lines) Patch
M src/builtins/builtins-array.cc View 1 36 chunks +129 lines, -108 lines 0 comments Download
M src/code-stub-assembler.h View 2 chunks +6 lines, -6 lines 0 comments Download
M src/code-stub-assembler.cc View 11 chunks +36 lines, -22 lines 0 comments Download
M src/code-stubs.cc View 8 chunks +26 lines, -24 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
Igor Sheludko
PTAL https://codereview.chromium.org/2319243002/diff/60001/src/builtins/builtins-array.cc File src/builtins/builtins-array.cc (right): https://codereview.chromium.org/2319243002/diff/60001/src/builtins/builtins-array.cc#newcode1325 src/builtins/builtins-array.cc:1325: // This round is lossless for all valid ...
4 years, 3 months ago (2016-09-08 11:07:52 UTC) #8
Jakob Kummerow
lgtm
4 years, 3 months ago (2016-09-08 11:55:46 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319243002/80001
4 years, 3 months ago (2016-09-08 11:57:16 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 3 months ago (2016-09-08 11:59:37 UTC) #17
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 11:59:50 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4ef7e3e7c710a1bef7ea21657113f3035111624b
Cr-Commit-Position: refs/heads/master@{#39276}

Powered by Google App Engine
This is Rietveld 408576698