Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2321543003: [stubs] CSA::LoadFixedDoubleArrayElement() is now able to do a hole check. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] CSA::LoadFixedDoubleArrayElement() is now able to do a hole check. Committed: https://crrev.com/ff06760b4037fdf776d6352789ee9c89ef53dc98 Cr-Commit-Position: refs/heads/master@{#39280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -104 lines) Patch
M src/builtins/builtins-array.cc View 4 chunks +13 lines, -74 lines 0 comments Download
M src/code-stub-assembler.h View 1 chunk +9 lines, -1 line 0 comments Download
M src/code-stub-assembler.cc View 4 chunks +27 lines, -29 lines 0 comments Download
M src/machine-type.h View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-08 11:57:29 UTC) #8
Jakob Kummerow
Very nice! LGTM.
4 years, 3 months ago (2016-09-08 12:58:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2321543003/20001
4 years, 3 months ago (2016-09-08 13:00:24 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-08 13:02:38 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 13:03:09 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ff06760b4037fdf776d6352789ee9c89ef53dc98
Cr-Commit-Position: refs/heads/master@{#39280}

Powered by Google App Engine
This is Rietveld 408576698