Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2319173002: [stubs] Fixing loads/stores from arrays by int32 offsets/indices. Step 2. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Fixing loads/stores from arrays by int32 offsets/indices. Step 2. Committed: https://crrev.com/82953686975346dfa105afec1063d1bdba11a071 Cr-Commit-Position: refs/heads/master@{#39271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -75 lines) Patch
M src/code-stub-assembler.h View 2 chunks +14 lines, -4 lines 0 comments Download
M src/code-stub-assembler.cc View 23 chunks +77 lines, -69 lines 0 comments Download
M test/cctest/test-code-stub-assembler.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 28 (23 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-07 16:59:48 UTC) #6
Jakob Kummerow
lgtm
4 years, 3 months ago (2016-09-08 10:54:30 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319173002/120001
4 years, 3 months ago (2016-09-08 10:55:00 UTC) #25
commit-bot: I haz the power
Committed patchset #1 (id:120001)
4 years, 3 months ago (2016-09-08 10:56:49 UTC) #26
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 10:57:21 UTC) #28
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82953686975346dfa105afec1063d1bdba11a071
Cr-Commit-Position: refs/heads/master@{#39271}

Powered by Google App Engine
This is Rietveld 408576698