Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2321643002:
[stubs] Introduce CSA::OptimalParameterMode(), TagParameter() and UntagParameter(). (Closed)
|
Created:
4 years, 3 months ago by Igor Sheludko Modified:
4 years, 3 months ago Reviewers:
Jakob Kummerow CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[stubs] Introduce CSA::OptimalParameterMode(), TagParameter() and UntagParameter().
Delete unused CSA::AllocateUninitializedFixedArray() which also does not
respect ParameterMode concept.
Committed: https://crrev.com/7dd7d9257b284073d9a55ce0ec4a881887d09ca0
Cr-Commit-Position: refs/heads/master@{#39268}
Patch Set 1 #
Dependent Patchsets: Messages
Total messages: 30 (24 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== [stubs] Introduce CSA::OptimalParameterMode(). Rename ParameterMode::INTEGER_PARAMETERS to INTPTR_PARAMETERS to avoid confusion in future. Delete unused CSA::AllocateUninitializedFixedArray() which also does not respect ParameterMode concept. ========== to ========== [stubs] Introduce CSA::OptimalParameterMode(), TagParameter() and UntagParameter(). Rename ParameterMode::INTEGER_PARAMETERS to INTPTR_PARAMETERS to avoid confusion in future. Delete unused CSA::AllocateUninitializedFixedArray() which also does not respect ParameterMode concept. ==========
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ishell@chromium.org changed reviewers: + jkummerow@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:20001) has been deleted
Description was changed from ========== [stubs] Introduce CSA::OptimalParameterMode(), TagParameter() and UntagParameter(). Rename ParameterMode::INTEGER_PARAMETERS to INTPTR_PARAMETERS to avoid confusion in future. Delete unused CSA::AllocateUninitializedFixedArray() which also does not respect ParameterMode concept. ========== to ========== [stubs] Introduce CSA::OptimalParameterMode(), TagParameter() and UntagParameter(). Delete unused CSA::AllocateUninitializedFixedArray() which also does not respect ParameterMode concept. ==========
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Patchset #2 (id:100001) has been deleted
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/12364) v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...) v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/12359) v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...) v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/12297) v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23585)
Patchset #1 (id:80001) has been deleted
The CQ bit was checked by ishell@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)
lgtm
The CQ bit was checked by ishell@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [stubs] Introduce CSA::OptimalParameterMode(), TagParameter() and UntagParameter(). Delete unused CSA::AllocateUninitializedFixedArray() which also does not respect ParameterMode concept. ========== to ========== [stubs] Introduce CSA::OptimalParameterMode(), TagParameter() and UntagParameter(). Delete unused CSA::AllocateUninitializedFixedArray() which also does not respect ParameterMode concept. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== [stubs] Introduce CSA::OptimalParameterMode(), TagParameter() and UntagParameter(). Delete unused CSA::AllocateUninitializedFixedArray() which also does not respect ParameterMode concept. ========== to ========== [stubs] Introduce CSA::OptimalParameterMode(), TagParameter() and UntagParameter(). Delete unused CSA::AllocateUninitializedFixedArray() which also does not respect ParameterMode concept. Committed: https://crrev.com/7dd7d9257b284073d9a55ce0ec4a881887d09ca0 Cr-Commit-Position: refs/heads/master@{#39268} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/7dd7d9257b284073d9a55ce0ec4a881887d09ca0 Cr-Commit-Position: refs/heads/master@{#39268} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
