Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(850)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2319033004: Updated audio quality test comments; win7 instructions were wrong. (Closed)

Created:
4 years, 3 months ago by phoglund_chromium
Modified:
4 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, tnakamura+watch_chromium.org, phoglund+watch_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated audio quality test comments; win7 instructions were wrong. BUG=625808 Committed: https://crrev.com/c7870d5460ec5aa32106bf3f0c384ae9fb4ada04 Cr-Commit-Position: refs/heads/master@{#417234}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
phoglund_chromium
4 years, 3 months ago (2016-09-07 15:21:45 UTC) #2
ehmaldonado_chromium
On 2016/09/07 15:21:45, phoglund_chrome wrote: LGTM
4 years, 3 months ago (2016-09-07 15:22:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319033004/1
4 years, 3 months ago (2016-09-08 07:12:19 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/292658)
4 years, 3 months ago (2016-09-08 07:14:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2319033004/20001
4 years, 3 months ago (2016-09-08 07:50:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 09:15:53 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 09:18:31 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/c7870d5460ec5aa32106bf3f0c384ae9fb4ada04
Cr-Commit-Position: refs/heads/master@{#417234}

Powered by Google App Engine
This is Rietveld 408576698