Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(979)

Side by Side Diff: chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc

Issue 2319033004: Updated audio quality test comments; win7 instructions were wrong. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 6
7 #include <ctime> 7 #include <ctime>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/files/file_enumerator.h" 10 #include "base/files/file_enumerator.h"
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 // 7. Try launching chrome as the target user on the target machine, try 112 // 7. Try launching chrome as the target user on the target machine, try
113 // playing, say, a YouTube video, and record with 'rec test.wav trim 0 5'. 113 // playing, say, a YouTube video, and record with 'rec test.wav trim 0 5'.
114 // Stop the video in chrome and try playing back the file; you should hear 114 // Stop the video in chrome and try playing back the file; you should hear
115 // a recording of the video (note; if you play back on the target machine 115 // a recording of the video (note; if you play back on the target machine
116 // you must revert the changes in step 3 first). 116 // you must revert the changes in step 3 first).
117 // 117 //
118 // On Windows 7: 118 // On Windows 7:
119 // 1. Control panel > Sound > Manage audio devices. 119 // 1. Control panel > Sound > Manage audio devices.
120 // 2. In the recording tab, right-click in an empty space in the pane with the 120 // 2. In the recording tab, right-click in an empty space in the pane with the
121 // devices. Tick 'show disabled devices'. 121 // devices. Tick 'show disabled devices'.
122 // 3. You should see a 'stero mix' device - this is what your speakers output. 122 // 3. You should see a 'stereo mix' device - this is what your speakers output.
123 // If you don't have one, your driver doesn't support stereo mix devices.
124 // Some drivers use different names for the mix device though (like "Wave").
123 // Right click > Properties. 125 // Right click > Properties.
124 // 4. In the Listen tab for the mix device, check the 'listen to this device' 126 // 4. Ensure "listen to this device" is unchecked, otherwise you get echo.
125 // checkbox. Ensure the mix device is the default recording device. 127 // 5. Ensure the mix device is the default recording device.
126 // 5. Launch chrome and try playing a video with sound. You should see 128 // 6. Launch chrome and try playing a video with sound. You should see
127 // in the volume meter for the mix device. Configure the mix device to have 129 // in the volume meter for the mix device. Configure the mix device to have
128 // 50 / 100 in level. Also go into the playback tab, right-click Speakers, 130 // 50 / 100 in level. Also go into the playback tab, right-click Speakers,
129 // and set that level to 50 / 100. Otherwise you will get distortion in 131 // and set that level to 50 / 100. Otherwise you will get distortion in
130 // the recording. 132 // the recording.
131 class MAYBE_WebRtcAudioQualityBrowserTest : public WebRtcTestBase { 133 class MAYBE_WebRtcAudioQualityBrowserTest : public WebRtcTestBase {
132 public: 134 public:
133 MAYBE_WebRtcAudioQualityBrowserTest() {} 135 MAYBE_WebRtcAudioQualityBrowserTest() {}
134 void SetUpInProcessBrowserTestFixture() override { 136 void SetUpInProcessBrowserTestFixture() override {
135 DetectErrorsInJavaScript(); // Look for errors in our rather complex js. 137 DetectErrorsInJavaScript(); // Look for errors in our rather complex js.
136 } 138 }
(...skipping 677 matching lines...) Expand 10 before | Expand all | Expand 10 after
814 MANUAL_TestAutoGainIsOffWithAudioProcessingOff 816 MANUAL_TestAutoGainIsOffWithAudioProcessingOff
815 #endif 817 #endif
816 // Since the AGC is off here there should be no gain at all. 818 // Since the AGC is off here there should be no gain at all.
817 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioQualityBrowserTest, 819 IN_PROC_BROWSER_TEST_F(MAYBE_WebRtcAudioQualityBrowserTest,
818 MAYBE_MANUAL_TestAutoGainIsOffWithAudioProcessingOff) { 820 MAYBE_MANUAL_TestAutoGainIsOffWithAudioProcessingOff) {
819 const char* kAudioCallWithoutAudioProcessing = 821 const char* kAudioCallWithoutAudioProcessing =
820 "{audio: { mandatory: { echoCancellation: false } } }"; 822 "{audio: { mandatory: { echoCancellation: false } } }";
821 ASSERT_NO_FATAL_FAILURE(TestAutoGainControl( 823 ASSERT_NO_FATAL_FAILURE(TestAutoGainControl(
822 kReferenceFile, kAudioCallWithoutAudioProcessing, "_no_agc")); 824 kReferenceFile, kAudioCallWithoutAudioProcessing, "_no_agc"));
823 } 825 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698