Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2224)

Unified Diff: chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc

Issue 2319033004: Updated audio quality test comments; win7 instructions were wrong. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc
diff --git a/chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc b/chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc
index 8588c49b9a7f09e94dcf4c7b2ba8c707588cd8d1..efdd9249ab048376afc73781fee266ec581fd7c3 100644
--- a/chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc
+++ b/chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc
@@ -119,11 +119,13 @@ const int kMaxAgcSegmentDiffMs =
// 1. Control panel > Sound > Manage audio devices.
// 2. In the recording tab, right-click in an empty space in the pane with the
// devices. Tick 'show disabled devices'.
-// 3. You should see a 'stero mix' device - this is what your speakers output.
+// 3. You should see a 'stereo mix' device - this is what your speakers output.
+// If you don't have one, your driver doesn't support stereo mix devices.
+// Some drivers use different names for the mix device though (like "Wave").
// Right click > Properties.
-// 4. In the Listen tab for the mix device, check the 'listen to this device'
-// checkbox. Ensure the mix device is the default recording device.
-// 5. Launch chrome and try playing a video with sound. You should see
+// 4. Ensure "listen to this device" is unchecked, otherwise you get echo.
+// 5. Ensure the mix device is the default recording device.
+// 6. Launch chrome and try playing a video with sound. You should see
// in the volume meter for the mix device. Configure the mix device to have
// 50 / 100 in level. Also go into the playback tab, right-click Speakers,
// and set that level to 50 / 100. Otherwise you will get distortion in
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698