Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2319003003:
Update SampleAndroidShadows to use algorithm closer to Android OpenGL (Closed)
|
Created:
4 years, 3 months ago by jvanverth1 Modified:
4 years, 3 months ago CC:
reviews_skia.org Target Ref:
refs/heads/master Project:
skia Visibility:
Public. |
DescriptionUpdate SampleAndroidShadows to use algorithm closer to Android OpenGL
Includes:
* Update light position to be at a similar distance to Android OS
* Scale spot shadows correctly
* Compute stroke shapes and radii correctly
* Allow for larger blur radius for shadows
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319003003
TBR=reed@google.com
NOTRY=true
NOTREECHECKS=true
Committed: https://skia.googlesource.com/skia/+/d99858ad46ca2c3b5c38061be8b006b25d24c6e0
Patch Set 1 #
Total comments: 4
Patch Set 2 : Address comments #Patch Set 3 : Fix up for high objects #Patch Set 4 : Fix translation for spot shadow #Patch Set 5 : Add largerBlur param to allow Android to keep workin #
Total comments: 1
Patch Set 6 : Address comment #
Messages
Total messages: 28 (17 generated)
Description was changed from ========== Update SampleAndroidShadows to use algorithm closer to Android OpenGL Includes: * Update light position to be at a similar distance to Android OS * Scale spot shadows correctly * Compute stroke shapes and radii correctly * Allow for larger blur radius for shadows ========== to ========== Update SampleAndroidShadows to use algorithm closer to Android OpenGL Includes: * Update light position to be at a similar distance to Android OS * Scale spot shadows correctly * Compute stroke shapes and radii correctly * Allow for larger blur radius for shadows GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319003003 ==========
Description was changed from ========== Update SampleAndroidShadows to use algorithm closer to Android OpenGL Includes: * Update light position to be at a similar distance to Android OS * Scale spot shadows correctly * Compute stroke shapes and radii correctly * Allow for larger blur radius for shadows GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319003003 ========== to ========== Update SampleAndroidShadows to use algorithm closer to Android OpenGL Includes: * Update light position to be at a similar distance to Android OS * Scale spot shadows correctly * Compute stroke shapes and radii correctly * Allow for larger blur radius for shadows GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319003003 ==========
jvanverth@google.com changed reviewers: + djsollen@google.com, herbderby@gmail.com
herb@google.com changed reviewers: + herb@google.com
https://codereview.chromium.org/2319003003/diff/1/samplecode/SampleAndroidSha... File samplecode/SampleAndroidShadows.cpp (right): https://codereview.chromium.org/2319003003/diff/1/samplecode/SampleAndroidSha... samplecode/SampleAndroidShadows.cpp:194: SkASSERT(pad < 64); how about: uint16_t iRadius = (uint16_t)(radius * 4.0f); then red is iRadius >> 8 and green is iRadius & 0xFF https://codereview.chromium.org/2319003003/diff/1/samplecode/SampleAndroidSha... samplecode/SampleAndroidShadows.cpp:290: pathRRect.transform(shadowXform, &shadowRRect); ....transform(SkMatrix::MakeScale(scale, scale), &shadowRRect);
herb@google.com changed reviewers: - herbderby@gmail.com
https://codereview.chromium.org/2319003003/diff/1/samplecode/SampleAndroidSha... File samplecode/SampleAndroidShadows.cpp (right): https://codereview.chromium.org/2319003003/diff/1/samplecode/SampleAndroidSha... samplecode/SampleAndroidShadows.cpp:194: SkASSERT(pad < 64); On 2016/09/07 18:22:00, herb_g wrote: > how about: > uint16_t iRadius = (uint16_t)(radius * 4.0f); > > then red is iRadius >> 8 and green is iRadius & 0xFF Done. https://codereview.chromium.org/2319003003/diff/1/samplecode/SampleAndroidSha... samplecode/SampleAndroidShadows.cpp:290: pathRRect.transform(shadowXform, &shadowRRect); On 2016/09/07 18:22:00, herb_g wrote: > ....transform(SkMatrix::MakeScale(scale, scale), &shadowRRect); Done.
jvanverth@google.com changed reviewers: + robertphillips@google.com
Adding Rob.
lgtm
jvanverth@google.com changed reviewers: + reed@google.com
I've done some more updates, so PTAL. This makes the shader compatible with the current Android code, and fixes up the pre-translate to be in the correct coordinate space.
lgtm https://codereview.chromium.org/2319003003/diff/80001/src/effects/SkGaussianE... File src/effects/SkGaussianEdgeShader.cpp (right): https://codereview.chromium.org/2319003003/diff/80001/src/effects/SkGaussianE... src/effects/SkGaussianEdgeShader.cpp:25: Add a TODO about removing largerBlur when the dep from Android is gone.
Description was changed from ========== Update SampleAndroidShadows to use algorithm closer to Android OpenGL Includes: * Update light position to be at a similar distance to Android OS * Scale spot shadows correctly * Compute stroke shapes and radii correctly * Allow for larger blur radius for shadows GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319003003 ========== to ========== Update SampleAndroidShadows to use algorithm closer to Android OpenGL Includes: * Update light position to be at a similar distance to Android OS * Scale spot shadows correctly * Compute stroke shapes and radii correctly * Allow for larger blur radius for shadows GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319003003 TBR=reed@google.com ==========
The CQ bit was checked by jvanverth@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from herb@google.com Link to the patchset: https://codereview.chromium.org/2319003003/#ps100001 (title: "Address comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by jvanverth@google.com
Description was changed from ========== Update SampleAndroidShadows to use algorithm closer to Android OpenGL Includes: * Update light position to be at a similar distance to Android OS * Scale spot shadows correctly * Compute stroke shapes and radii correctly * Allow for larger blur radius for shadows GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319003003 TBR=reed@google.com ========== to ========== Update SampleAndroidShadows to use algorithm closer to Android OpenGL Includes: * Update light position to be at a similar distance to Android OS * Scale spot shadows correctly * Compute stroke shapes and radii correctly * Allow for larger blur radius for shadows GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319003003 TBR=reed@google.com NOTRY=true ==========
The CQ bit was checked by jvanverth@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Update SampleAndroidShadows to use algorithm closer to Android OpenGL Includes: * Update light position to be at a similar distance to Android OS * Scale spot shadows correctly * Compute stroke shapes and radii correctly * Allow for larger blur radius for shadows GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319003003 TBR=reed@google.com NOTRY=true ========== to ========== Update SampleAndroidShadows to use algorithm closer to Android OpenGL Includes: * Update light position to be at a similar distance to Android OS * Scale spot shadows correctly * Compute stroke shapes and radii correctly * Allow for larger blur radius for shadows GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319003003 TBR=reed@google.com NOTRY=true NOTREECHECKS=true ==========
The CQ bit was unchecked by jvanverth@google.com
The CQ bit was checked by jvanverth@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Update SampleAndroidShadows to use algorithm closer to Android OpenGL Includes: * Update light position to be at a similar distance to Android OS * Scale spot shadows correctly * Compute stroke shapes and radii correctly * Allow for larger blur radius for shadows GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319003003 TBR=reed@google.com NOTRY=true NOTREECHECKS=true ========== to ========== Update SampleAndroidShadows to use algorithm closer to Android OpenGL Includes: * Update light position to be at a similar distance to Android OS * Scale spot shadows correctly * Compute stroke shapes and radii correctly * Allow for larger blur radius for shadows GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2319003003 TBR=reed@google.com NOTRY=true NOTREECHECKS=true Committed: https://skia.googlesource.com/skia/+/d99858ad46ca2c3b5c38061be8b006b25d24c6e0 ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://skia.googlesource.com/skia/+/d99858ad46ca2c3b5c38061be8b006b25d24c6e0 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
