Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2318493003: Clean up PathUtils unused parameters. (Closed)

Created:
4 years, 3 months ago by Peter Wen
Modified:
4 years, 3 months ago
CC:
chromium-reviews, kalyank, cbentzel+watch_chromium.org, sadrul, android-webview-reviews_chromium.org, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up PathUtils unused parameters. The context parameters are no longer necessary for PathUtils. BUG=644377 Committed: https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41 Cr-Commit-Position: refs/heads/master@{#417272}

Patch Set 1 #

Patch Set 2 : Fix more. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -56 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java View 1 chunk +1 line, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/PathUtils.java View 1 5 chunks +7 lines, -8 lines 0 comments Download
M base/android/java/src/org/chromium/base/ResourceExtractor.java View 1 chunk +1 line, -1 line 0 comments Download
M base/android/java/src/org/chromium/base/library_loader/ModernLinker.java View 1 chunk +1 line, -1 line 0 comments Download
M base/android/path_utils.cc View 1 6 chunks +6 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabbedModeTabPersistencePolicy.java View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestContextTest.java View 14 chunks +14 lines, -14 lines 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/DiskStorageTest.java View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/javatests/src/org/chromium/net/ExperimentalOptionsTest.java View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java View 2 chunks +8 lines, -8 lines 0 comments Download
M components/cronet/android/test/src/org/chromium/net/TestFilesInstaller.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Peter Wen
Hi Andrew, This is moving towards a world where we can fully rely on ContextUtils.getApplicationContext ...
4 years, 3 months ago (2016-09-06 18:28:41 UTC) #4
agrieve
On 2016/09/06 18:28:41, Peter Wen wrote: > Hi Andrew, > > This is moving towards ...
4 years, 3 months ago (2016-09-06 18:39:13 UTC) #5
Peter Wen
+sgurun@ for android_webview OWNERS. +tedchoc@ for chrome/android OWNERS. +xunjieli@ for components/cronet OWNERS.
4 years, 3 months ago (2016-09-06 18:47:59 UTC) #7
xunjieli
> +xunjieli@ for components/cronet OWNERS. LGTM. Cronet isn't on CQ yet. Out of paranoia, could ...
4 years, 3 months ago (2016-09-06 18:53:30 UTC) #8
Ted C
On 2016/09/06 18:53:30, xunjieli wrote: > > +xunjieli@ for components/cronet OWNERS. > LGTM. Cronet isn't ...
4 years, 3 months ago (2016-09-06 18:57:29 UTC) #9
sgurun-gerrit only
On 2016/09/06 18:57:29, Ted C wrote: > On 2016/09/06 18:53:30, xunjieli wrote: > > > ...
4 years, 3 months ago (2016-09-07 23:32:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2318493003/20001
4 years, 3 months ago (2016-09-08 12:53:40 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 13:32:32 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 13:33:47 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9c8dc6d2170f138ce81f195b6ffa0da3b046bd41
Cr-Commit-Position: refs/heads/master@{#417272}

Powered by Google App Engine
This is Rietveld 408576698