Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2758)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java

Issue 2318493003: Clean up PathUtils unused parameters. (Closed)
Patch Set: Fix more. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java
index 6706a3ddba953e57e62480c3c11280408a1af51b..37fd70f15272974c8dc39245ea72e298665f9461 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpDirectoryObserver.java
@@ -22,11 +22,10 @@ import java.io.File;
public class MinidumpDirectoryObserver extends FileObserver {
private static final String TAG = "MinidumpDirObserver";
- private static Context sContext = ContextUtils.getApplicationContext();
public MinidumpDirectoryObserver() {
// The file observer detects MOVED_TO for child processes.
- super(new File(PathUtils.getCacheDirectory(sContext),
+ super(new File(PathUtils.getCacheDirectory(),
CrashFileManager.CRASH_DUMP_DIR).toString(), FileObserver.MOVED_TO);
}
@@ -37,9 +36,11 @@ public class MinidumpDirectoryObserver extends FileObserver {
public void onEvent(int event, String path) {
// This is executed on a thread dedicated to FileObserver.
if (CrashFileManager.isMinidumpMIMEFirstTry(path)) {
+ Context appContext = ContextUtils.getApplicationContext();
try {
- Intent intent = MinidumpUploadService.createFindAndUploadLastCrashIntent(sContext);
- sContext.startService(intent);
+ Intent intent =
+ MinidumpUploadService.createFindAndUploadLastCrashIntent(appContext);
+ appContext.startService(intent);
Log.i(TAG, "Detects a new minidump %s send intent to MinidumpUploadService", path);
RecordUserAction.record("MobileBreakpadUploadAttempt");
} catch (SecurityException e) {

Powered by Google App Engine
This is Rietveld 408576698