android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java - Issue 2318493003: Clean up PathUtils unused parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java

Issue 2318493003: Clean up PathUtils unused parameters. (Closed)

Patch Set: Fix more. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java ('k') | base/android/java/src/org/chromium/base/PathUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java

index 3c9e234ebee313cdd2b89e50a722abca5281630a..c51ff40cb53390a085bad1f4632bbea6da77b83c 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/HttpCacheTest.java

@@ -73,7 +73,7 @@ public class HttpCacheTest extends AwTestBase {

Context appContext = getInstrumentation().getTargetContext().getApplicationContext();

PathUtils.setPrivateDataDirectorySuffix(

AwBrowserProcess.PRIVATE_DATA_DIRECTORY_SUFFIX, appContext);

- File webViewLegacyCacheDir = new File(PathUtils.getDataDirectory(appContext), "Cache");

+ File webViewLegacyCacheDir = new File(PathUtils.getDataDirectory(), "Cache");

if (!webViewLegacyCacheDir.isDirectory()) {

assertTrue(webViewLegacyCacheDir.mkdir());

assertTrue(webViewLegacyCacheDir.isDirectory());