Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2317953002: cc: Merge the DrawLayer()/DrawFrame() and SwapBuffers() methods. (Closed)

Created:
4 years, 3 months ago by danakj
Modified:
4 years, 3 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Merge the DrawLayer()/DrawFrame() and SwapBuffers() methods. This deletes the SwapBuffers() method in LayerTreeHostImpl and in DelegatingRenderer, merging them into DrawLayers() and DrawFrame() in their respective classes. Next up is to collapse DelegatingRenderer into LayerTreeHostImpl and remove all "renderer" and "draw and swap" terminology in LayerTreeHostImpl, Scheduler, Proxies and friends. R=enne BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/aecfcfba7f2622ab3fa1691e939f76ca30a74f2d Cr-Commit-Position: refs/heads/master@{#417098}

Patch Set 1 #

Patch Set 2 : merge-draw-swap-2: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -129 lines) Patch
M cc/output/delegating_renderer.h View 1 chunk +2 lines, -4 lines 0 comments Download
M cc/output/delegating_renderer.cc View 3 chunks +10 lines, -15 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 3 chunks +45 lines, -55 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 41 chunks +6 lines, -47 lines 0 comments Download
M cc/trees/proxy_impl.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
danakj
4 years, 3 months ago (2016-09-07 19:06:08 UTC) #2
enne (OOO)
lgtm
4 years, 3 months ago (2016-09-07 21:38:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317953002/20001
4 years, 3 months ago (2016-09-07 22:22:40 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 22:33:43 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 22:36:06 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aecfcfba7f2622ab3fa1691e939f76ca30a74f2d
Cr-Commit-Position: refs/heads/master@{#417098}

Powered by Google App Engine
This is Rietveld 408576698