Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Issue 2323583002: cc: Remove DelegatingRenderer. (Closed)

Created:
4 years, 3 months ago by danakj
Modified:
4 years, 3 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove DelegatingRenderer. Inline the tiny code left there into LayerTreeHostImpl, delete the |renderer_| member and change references to the |output_surface_| instead. R=enne BUG=641613 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7 Cr-Commit-Position: refs/heads/master@{#417150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -251 lines) Patch
M cc/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
D cc/output/delegating_renderer.h View 1 chunk +0 lines, -36 lines 0 comments Download
D cc/output/delegating_renderer.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D cc/output/delegating_renderer_unittest.cc View 1 chunk +0 lines, -103 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 6 chunks +3 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 11 chunks +33 lines, -39 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +86 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
danakj
4 years, 3 months ago (2016-09-08 00:22:07 UTC) #4
enne (OOO)
lgtm
4 years, 3 months ago (2016-09-08 00:30:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323583002/1
4 years, 3 months ago (2016-09-08 01:05:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 01:34:14 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 01:36:10 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd23d696d66885e88e53dd5f9b8ff6d0549d6ad7
Cr-Commit-Position: refs/heads/master@{#417150}

Powered by Google App Engine
This is Rietveld 408576698