Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2314323003: cc: Remove ScopedTrackers in SingleThreadProxy. (Closed)

Created:
4 years, 3 months ago by danakj
Modified:
4 years, 3 months ago
Reviewers:
sunnyps
CC:
chromium-reviews, cc-bugs_chromium.org, enne (OOO), piman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove ScopedTrackers in SingleThreadProxy and Scheduler. We're not actively using them and they make code hard to read and change. R=sunnyps@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/1a856cfa17f418992b9898762ce546d3d5e43f10 Cr-Commit-Position: refs/heads/master@{#417074}

Patch Set 1 #

Patch Set 2 : scopedtrackers #

Patch Set 3 : scopedtrackers: rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -79 lines) Patch
M cc/scheduler/scheduler.cc View 1 3 chunks +1 line, -17 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 2 5 chunks +0 lines, -62 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 23 (16 generated)
danakj
4 years, 3 months ago (2016-09-07 00:36:01 UTC) #2
sunnyps
Can you also remove the ScopedTracker from cc scheduler please? I think that's the only ...
4 years, 3 months ago (2016-09-07 00:42:54 UTC) #5
danakj
Done, PTAL. That is all of them in cc/
4 years, 3 months ago (2016-09-07 00:51:26 UTC) #7
sunnyps
lgtm
4 years, 3 months ago (2016-09-07 00:57:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314323003/40001
4 years, 3 months ago (2016-09-07 21:40:14 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-07 22:06:04 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 22:07:46 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1a856cfa17f418992b9898762ce546d3d5e43f10
Cr-Commit-Position: refs/heads/master@{#417074}

Powered by Google App Engine
This is Rietveld 408576698