Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Issue 2317703002: Enable use of intermediate source set by iOS templates. (Closed)

Created:
4 years, 3 months ago by sdefresne
Modified:
4 years, 3 months ago
Reviewers:
Olivier
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable use of intermediate source set by iOS templates. Enable use of intermediate source set by ios_app_bundle and ios_framework_bundle templates as this should reduce false dependencies. BUG=637065 Committed: https://crrev.com/0cbc7aa6773e0085993968788af9cc4efafc4b81 Cr-Commit-Position: refs/heads/master@{#416906}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/ios/rules.gni View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
sdefresne
Please take a look.
4 years, 3 months ago (2016-09-06 15:27:39 UTC) #7
Olivier
lgtm
4 years, 3 months ago (2016-09-06 15:38:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317703002/20001
4 years, 3 months ago (2016-09-07 11:05:31 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-07 11:09:01 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 11:11:30 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0cbc7aa6773e0085993968788af9cc4efafc4b81
Cr-Commit-Position: refs/heads/master@{#416906}

Powered by Google App Engine
This is Rietveld 408576698