Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2314053002: Fix ios_framework_bundle target when using intermediate source sets. (Closed)

Created:
4 years, 3 months ago by sdefresne
Modified:
4 years, 3 months ago
Reviewers:
Olivier
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix ios_framework_bundle target when using intermediate source sets. Split the config that add the header map to the include dirs and pass the -install_name flag to the linker as the former is only used while compiling the source file and the latter is only used by the link step. BUG=637065 Committed: https://crrev.com/c6c0b40fcf2fd87ca23e90f6bd352267b9fd080f Cr-Commit-Position: refs/heads/master@{#416639}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/config/ios/rules.gni View 3 chunks +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
sdefresne
Please take a look and send to CQ if LGTY.
4 years, 3 months ago (2016-09-06 15:27:16 UTC) #4
Olivier
lgtm
4 years, 3 months ago (2016-09-06 15:37:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2314053002/1
4 years, 3 months ago (2016-09-06 15:46:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 16:35:10 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 16:36:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6c0b40fcf2fd87ca23e90f6bd352267b9fd080f
Cr-Commit-Position: refs/heads/master@{#416639}

Powered by Google App Engine
This is Rietveld 408576698