content/renderer/render_view_impl.h - Issue 23171029: Fix a crash that EnsureMediaStreamClient() does not guarantee media_stream_client_ get created

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.h

Issue 23171029: Fix a crash that EnsureMediaStreamClient() does not guarantee media_stream_client_ get created (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add TODO Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.h

diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h

index 8571234d5bd1266b17c5be9071b49d6f1ee7769f..f7a3055f44b413bd534d2d6fc1a3b05ae8643e07 100644

--- a/content/renderer/render_view_impl.h

+++ b/content/renderer/render_view_impl.h

@@ -1092,6 +1092,9 @@ class CONTENT_EXPORT RenderViewImpl

void CheckPreferredSize();

// Initializes |media_stream_client_| if needed.

+ // TODO(qinmin): rename this function as it does not guarantee

+ // |media_stream_client_| will be created.

+ // http://crbug.com/278490.

void EnsureMediaStreamClient();

// This callback is triggered when DownloadFavicon completes, either

« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »