content/renderer/render_view_impl.cc - Issue 23171029: Fix a crash that EnsureMediaStreamClient() does not guarantee media_stream_client_ get created

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_view_impl.cc

Issue 23171029: Fix a crash that EnsureMediaStreamClient() does not guarantee media_stream_client_ get created (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add TODO Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/render_view_impl.cc

diff --git a/content/renderer/render_view_impl.cc b/content/renderer/render_view_impl.cc

index 5bde8ba8cedd502b2668b7fe50b4b85917b9565b..86eb093423d522daee568b284b9bb4c1bc783760 100644

--- a/content/renderer/render_view_impl.cc

+++ b/content/renderer/render_view_impl.cc

@@ -3002,7 +3002,7 @@ WebMediaPlayer* RenderViewImpl::createMediaPlayer(

#if defined(ENABLE_WEBRTC)

EnsureMediaStreamClient();

#if !defined(GOOGLE_TV)

- if (media_stream_client_->IsMediaStream(url)) {

+ if (media_stream_client_ && media_stream_client_->IsMediaStream(url)) {

#if defined(OS_ANDROID) && defined(ARCH_CPU_ARMEL)

bool found_neon =

(android_getCpuFeatures() & ANDROID_CPU_ARM_FEATURE_NEON) != 0;

« no previous file with comments | « content/renderer/render_view_impl.h ('k') | no next file » | no next file with comments »