Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 23171029: Fix a crash that EnsureMediaStreamClient() does not guarantee media_stream_client_ get created (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add TODO Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 1074 matching lines...) Expand 10 before | Expand all | Expand 10 after
1085 1085
1086 void AltErrorPageFinished(WebKit::WebFrame* frame, 1086 void AltErrorPageFinished(WebKit::WebFrame* frame,
1087 const WebKit::WebURLRequest& original_request, 1087 const WebKit::WebURLRequest& original_request,
1088 const WebKit::WebURLError& original_error, 1088 const WebKit::WebURLError& original_error,
1089 const std::string& html); 1089 const std::string& html);
1090 1090
1091 // Check whether the preferred size has changed. 1091 // Check whether the preferred size has changed.
1092 void CheckPreferredSize(); 1092 void CheckPreferredSize();
1093 1093
1094 // Initializes |media_stream_client_| if needed. 1094 // Initializes |media_stream_client_| if needed.
1095 // TODO(qinmin): rename this function as it does not guarantee
1096 // |media_stream_client_| will be created.
1097 // http://crbug.com/278490.
1095 void EnsureMediaStreamClient(); 1098 void EnsureMediaStreamClient();
1096 1099
1097 // This callback is triggered when DownloadFavicon completes, either 1100 // This callback is triggered when DownloadFavicon completes, either
1098 // succesfully or with a failure. See DownloadFavicon for more 1101 // succesfully or with a failure. See DownloadFavicon for more
1099 // details. 1102 // details.
1100 void DidDownloadFavicon(ImageResourceFetcher* fetcher, 1103 void DidDownloadFavicon(ImageResourceFetcher* fetcher,
1101 const SkBitmap& image); 1104 const SkBitmap& image);
1102 1105
1103 // Requests to download a favicon image. When done, the RenderView is notified 1106 // Requests to download a favicon image. When done, the RenderView is notified
1104 // by way of DidDownloadFavicon. Returns true if the request was successfully 1107 // by way of DidDownloadFavicon. Returns true if the request was successfully
(...skipping 470 matching lines...) Expand 10 before | Expand all | Expand 10 after
1575 // use the Observer interface to filter IPC messages and receive frame change 1578 // use the Observer interface to filter IPC messages and receive frame change
1576 // notifications. 1579 // notifications.
1577 // --------------------------------------------------------------------------- 1580 // ---------------------------------------------------------------------------
1578 1581
1579 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1582 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1580 }; 1583 };
1581 1584
1582 } // namespace content 1585 } // namespace content
1583 1586
1584 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1587 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698