sync and signin: Change ScopedTempDir::path() to GetPath()

chrome/browser/sync_file_system/local/local_file_sync_context_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync_file_system/local/local_file_sync_context.h"
 
 #include <stdint.h>
 #include <utility>
 #include <vector>
 
@@ skipping 220 matching lines @@
     }
   }
 
   void PrepareForSync_Basic(LocalFileSyncContext::SyncMode sync_mode,
                             SyncStatusCode simulate_sync_finish_status) {
     CannedSyncableFileSystem file_system(GURL(kOrigin1),
                                          in_memory_env_.get(),
                                          io_task_runner_.get(),
                                          file_task_runner_.get());
     file_system.SetUp(CannedSyncableFileSystem::QUOTA_ENABLED);
-    sync_context_ = new LocalFileSyncContext(
-        dir_.path(), in_memory_env_.get(),
-        ui_task_runner_.get(), io_task_runner_.get());
+    sync_context_ =
+        new LocalFileSyncContext(dir_.GetPath(), in_memory_env_.get(),
+                                 ui_task_runner_.get(), io_task_runner_.get());
     ASSERT_EQ(SYNC_STATUS_OK,
               file_system.MaybeInitializeFileSystemContext(
                   sync_context_.get()));
     ASSERT_EQ(base::File::FILE_OK, file_system.OpenFileSystem());
 
     const FileSystemURL kFile(file_system.URL("file"));
     EXPECT_EQ(base::File::FILE_OK, file_system.CreateFile(kFile));
 
     SyncFileMetadata metadata;
     FileChangeList changes;
@@ skipping 29 matching lines @@
     file_system.TearDown();
   }
 
   void PrepareForSync_WriteDuringSync(
       LocalFileSyncContext::SyncMode sync_mode) {
     CannedSyncableFileSystem file_system(GURL(kOrigin1),
                                          in_memory_env_.get(),
                                          io_task_runner_.get(),
                                          file_task_runner_.get());
     file_system.SetUp(CannedSyncableFileSystem::QUOTA_ENABLED);
-    sync_context_ = new LocalFileSyncContext(
-        dir_.path(), in_memory_env_.get(),
-        ui_task_runner_.get(), io_task_runner_.get());
+    sync_context_ =
+        new LocalFileSyncContext(dir_.GetPath(), in_memory_env_.get(),
+                                 ui_task_runner_.get(), io_task_runner_.get());
     ASSERT_EQ(SYNC_STATUS_OK,
               file_system.MaybeInitializeFileSystemContext(
                   sync_context_.get()));
     ASSERT_EQ(base::File::FILE_OK, file_system.OpenFileSystem());
 
     const FileSystemURL kFile(file_system.URL("file"));
     EXPECT_EQ(base::File::FILE_OK, file_system.CreateFile(kFile));
 
     SyncFileMetadata metadata;
     FileChangeList changes;
@@ skipping 55 matching lines @@
   scoped_refptr<LocalFileSyncContext> sync_context_;
 
   SyncStatusCode status_;
   base::File::Error file_error_;
   bool async_modify_finished_;
   bool has_inflight_prepare_for_sync_;
 };
 
 TEST_F(LocalFileSyncContextTest, ConstructAndDestruct) {
   sync_context_ =
-      new LocalFileSyncContext(
-          dir_.path(), in_memory_env_.get(),
-          ui_task_runner_.get(), io_task_runner_.get());
+      new LocalFileSyncContext(dir_.GetPath(), in_memory_env_.get(),
+                               ui_task_runner_.get(), io_task_runner_.get());
   sync_context_->ShutdownOnUIThread();
 }
 
 TEST_F(LocalFileSyncContextTest, InitializeFileSystemContext) {
   CannedSyncableFileSystem file_system(GURL(kOrigin1),
                                        in_memory_env_.get(),
                                        io_task_runner_.get(),
                                        file_task_runner_.get());
   file_system.SetUp(CannedSyncableFileSystem::QUOTA_ENABLED);
 
-  sync_context_ = new LocalFileSyncContext(
-      dir_.path(), in_memory_env_.get(),
-      ui_task_runner_.get(), io_task_runner_.get());
+  sync_context_ =
+      new LocalFileSyncContext(dir_.GetPath(), in_memory_env_.get(),
+                               ui_task_runner_.get(), io_task_runner_.get());
 
   // Initializes file_system using |sync_context_|.
   EXPECT_EQ(SYNC_STATUS_OK,
             file_system.MaybeInitializeFileSystemContext(sync_context_.get()));
 
   // Make sure everything's set up for file_system to be able to handle
   // syncable file system operations.
   EXPECT_TRUE(file_system.backend()->sync_context() != nullptr);
   EXPECT_TRUE(file_system.backend()->change_tracker() != nullptr);
   EXPECT_EQ(sync_context_.get(), file_system.backend()->sync_context());
@@ skipping 25 matching lines @@
                                         in_memory_env_.get(),
                                         io_task_runner_.get(),
                                         file_task_runner_.get());
   CannedSyncableFileSystem file_system2(GURL(kOrigin2),
                                         in_memory_env_.get(),
                                         io_task_runner_.get(),
                                         file_task_runner_.get());
   file_system1.SetUp(CannedSyncableFileSystem::QUOTA_ENABLED);
   file_system2.SetUp(CannedSyncableFileSystem::QUOTA_ENABLED);
 
-  sync_context_ = new LocalFileSyncContext(
-      dir_.path(), in_memory_env_.get(),
-      ui_task_runner_.get(), io_task_runner_.get());
+  sync_context_ =
+      new LocalFileSyncContext(dir_.GetPath(), in_memory_env_.get(),
+                               ui_task_runner_.get(), io_task_runner_.get());
 
   // Initializes file_system1 and file_system2.
   EXPECT_EQ(SYNC_STATUS_OK,
             file_system1.MaybeInitializeFileSystemContext(sync_context_.get()));
   EXPECT_EQ(SYNC_STATUS_OK,
             file_system2.MaybeInitializeFileSystemContext(sync_context_.get()));
 
   EXPECT_EQ(base::File::FILE_OK, file_system1.OpenFileSystem());
   EXPECT_EQ(base::File::FILE_OK, file_system2.OpenFileSystem());
 
@@ skipping 90 matching lines @@
 // LocalFileSyncContextTest.PrepareSyncWhileWriting is flaky on android.
 // http://crbug.com/239793
 // It is also flaky on the TSAN v2 bots, and hangs other bots.
 // http://crbug.com/305905.
 TEST_F(LocalFileSyncContextTest, DISABLED_PrepareSyncWhileWriting) {
   CannedSyncableFileSystem file_system(GURL(kOrigin1),
                                        in_memory_env_.get(),
                                        io_task_runner_.get(),
                                        file_task_runner_.get());
   file_system.SetUp(CannedSyncableFileSystem::QUOTA_ENABLED);
-  sync_context_ = new LocalFileSyncContext(
-      dir_.path(), in_memory_env_.get(),
-      ui_task_runner_.get(), io_task_runner_.get());
+  sync_context_ =
+      new LocalFileSyncContext(dir_.GetPath(), in_memory_env_.get(),
+                               ui_task_runner_.get(), io_task_runner_.get());
   EXPECT_EQ(SYNC_STATUS_OK,
             file_system.MaybeInitializeFileSystemContext(sync_context_.get()));
 
   EXPECT_EQ(base::File::FILE_OK, file_system.OpenFileSystem());
 
   const FileSystemURL kURL1(file_system.URL("foo"));
 
   // Creates a file in file_system.
   EXPECT_EQ(base::File::FILE_OK, file_system.CreateFile(kURL1));
 
@@ skipping 41 matching lines @@
   file_system.TearDown();
 }
 
 TEST_F(LocalFileSyncContextTest, ApplyRemoteChangeForDeletion) {
   CannedSyncableFileSystem file_system(GURL(kOrigin1),
                                        in_memory_env_.get(),
                                        io_task_runner_.get(),
                                        file_task_runner_.get());
   file_system.SetUp(CannedSyncableFileSystem::QUOTA_ENABLED);
 
-  sync_context_ = new LocalFileSyncContext(
-      dir_.path(), in_memory_env_.get(),
-      ui_task_runner_.get(), io_task_runner_.get());
+  sync_context_ =
+      new LocalFileSyncContext(dir_.GetPath(), in_memory_env_.get(),
+                               ui_task_runner_.get(), io_task_runner_.get());
   ASSERT_EQ(SYNC_STATUS_OK,
             file_system.MaybeInitializeFileSystemContext(sync_context_.get()));
   ASSERT_EQ(base::File::FILE_OK, file_system.OpenFileSystem());
 
   // Record the initial usage (likely 0).
   int64_t initial_usage = -1;
   int64_t quota = -1;
   EXPECT_EQ(storage::kQuotaStatusOk,
             file_system.GetUsageAndQuota(&initial_usage, &quota));
 
@@ skipping 65 matching lines @@
   file_system.TearDown();
 }
 
 TEST_F(LocalFileSyncContextTest, ApplyRemoteChangeForDeletion_ForRoot) {
   CannedSyncableFileSystem file_system(GURL(kOrigin1),
                                        in_memory_env_.get(),
                                        io_task_runner_.get(),
                                        file_task_runner_.get());
   file_system.SetUp(CannedSyncableFileSystem::QUOTA_ENABLED);
 
-  sync_context_ = new LocalFileSyncContext(
-      dir_.path(), in_memory_env_.get(),
-      ui_task_runner_.get(), io_task_runner_.get());
+  sync_context_ =
+      new LocalFileSyncContext(dir_.GetPath(), in_memory_env_.get(),
+                               ui_task_runner_.get(), io_task_runner_.get());
   ASSERT_EQ(SYNC_STATUS_OK,
             file_system.MaybeInitializeFileSystemContext(sync_context_.get()));
   ASSERT_EQ(base::File::FILE_OK, file_system.OpenFileSystem());
 
   // Record the initial usage (likely 0).
   int64_t initial_usage = -1;
   int64_t quota = -1;
   EXPECT_EQ(storage::kQuotaStatusOk,
             file_system.GetUsageAndQuota(&initial_usage, &quota));
 
@@ skipping 47 matching lines @@
 TEST_F(LocalFileSyncContextTest, ApplyRemoteChangeForAddOrUpdate) {
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
 
   CannedSyncableFileSystem file_system(GURL(kOrigin1),
                                        in_memory_env_.get(),
                                        io_task_runner_.get(),
                                        file_task_runner_.get());
   file_system.SetUp(CannedSyncableFileSystem::QUOTA_ENABLED);
 
-  sync_context_ = new LocalFileSyncContext(
-      dir_.path(), in_memory_env_.get(),
-      ui_task_runner_.get(), io_task_runner_.get());
+  sync_context_ =
+      new LocalFileSyncContext(dir_.GetPath(), in_memory_env_.get(),
+                               ui_task_runner_.get(), io_task_runner_.get());
   ASSERT_EQ(SYNC_STATUS_OK,
             file_system.MaybeInitializeFileSystemContext(sync_context_.get()));
   ASSERT_EQ(base::File::FILE_OK, file_system.OpenFileSystem());
 
   const FileSystemURL kFile1(file_system.URL("file1"));
   const FileSystemURL kFile2(file_system.URL("file2"));
   const FileSystemURL kDir(file_system.URL("dir"));
 
   const char kTestFileData0[] = "0123456789";
   const char kTestFileData1[] = "Lorem ipsum!";
@@ skipping 11 matching lines @@
             file_system.DirectoryExists(kDir));
 
   // file_system's change tracker must have recorded the creation.
   FileSystemURLSet urls;
   file_system.GetChangedURLsInTracker(&urls);
   ASSERT_EQ(1U, urls.size());
   EXPECT_TRUE(base::ContainsKey(urls, kFile1));
   file_system.ClearChangeForURLInTracker(*urls.begin());
 
   // Prepare temporary files which represent the remote file data.
-  const base::FilePath kFilePath1(temp_dir.path().Append(FPL("file1")));
-  const base::FilePath kFilePath2(temp_dir.path().Append(FPL("file2")));
+  const base::FilePath kFilePath1(temp_dir.GetPath().Append(FPL("file1")));
+  const base::FilePath kFilePath2(temp_dir.GetPath().Append(FPL("file2")));
 
   ASSERT_EQ(static_cast<int>(arraysize(kTestFileData1) - 1),
             base::WriteFile(kFilePath1, kTestFileData1,
                             arraysize(kTestFileData1) - 1));
   ASSERT_EQ(static_cast<int>(arraysize(kTestFileData2) - 1),
             base::WriteFile(kFilePath2, kTestFileData2,
                             arraysize(kTestFileData2) - 1));
 
   // Record the usage.
   int64_t usage = -1, new_usage = -1;
@@ skipping 95 matching lines @@
 TEST_F(LocalFileSyncContextTest, ApplyRemoteChangeForAddOrUpdate_NoParent) {
   base::ScopedTempDir temp_dir;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
 
   CannedSyncableFileSystem file_system(GURL(kOrigin1),
                                        in_memory_env_.get(),
                                        io_task_runner_.get(),
                                        file_task_runner_.get());
   file_system.SetUp(CannedSyncableFileSystem::QUOTA_ENABLED);
 
-  sync_context_ = new LocalFileSyncContext(
-      dir_.path(), in_memory_env_.get(),
-      ui_task_runner_.get(), io_task_runner_.get());
+  sync_context_ =
+      new LocalFileSyncContext(dir_.GetPath(), in_memory_env_.get(),
+                               ui_task_runner_.get(), io_task_runner_.get());
   ASSERT_EQ(SYNC_STATUS_OK,
             file_system.MaybeInitializeFileSystemContext(sync_context_.get()));
   ASSERT_EQ(base::File::FILE_OK, file_system.OpenFileSystem());
 
   const char kTestFileData[] = "Lorem ipsum!";
   const FileSystemURL kDir(file_system.URL("dir"));
   const FileSystemURL kFile(file_system.URL("dir/file"));
 
   // Either kDir or kFile not exist yet.
   EXPECT_EQ(base::File::FILE_ERROR_NOT_FOUND, file_system.FileExists(kDir));
   EXPECT_EQ(base::File::FILE_ERROR_NOT_FOUND, file_system.FileExists(kFile));
 
   // Prepare a temporary file which represents remote file data.
-  const base::FilePath kFilePath(temp_dir.path().Append(FPL("file")));
+  const base::FilePath kFilePath(temp_dir.GetPath().Append(FPL("file")));
   ASSERT_EQ(static_cast<int>(arraysize(kTestFileData) - 1),
             base::WriteFile(kFilePath, kTestFileData,
                             arraysize(kTestFileData) - 1));
 
   // Calling ApplyChange's with kFilePath should create
   // kFile along with kDir.
   FileChange change(FileChange::FILE_CHANGE_ADD_OR_UPDATE,
                     SYNC_FILE_TYPE_FILE);
   EXPECT_EQ(SYNC_STATUS_OK,
             ApplyRemoteChange(file_system.file_system_context(),
                               change, kFilePath, kFile,
                               SYNC_FILE_TYPE_UNKNOWN));
 
   // The changes applied by ApplyRemoteChange should not be recorded in
   // the change tracker.
   FileSystemURLSet urls;
   urls.clear();
   file_system.GetChangedURLsInTracker(&urls);
   EXPECT_TRUE(urls.empty());
 
   // Make sure kDir and kFile are created by ApplyRemoteChange.
   EXPECT_EQ(base::File::FILE_OK, file_system.FileExists(kFile));
   EXPECT_EQ(base::File::FILE_OK, file_system.DirectoryExists(kDir));
 
   sync_context_->ShutdownOnUIThread();
   file_system.TearDown();
 }
 
 }  // namespace sync_file_system