Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2317003002: //chrome/browser and //components F-L: Change ScopedTempDir::path() to GetPath() (Closed)

Created:
4 years, 3 months ago by vabr (Chromium)
Modified:
4 years, 3 months ago
CC:
browser-components-watch_chromium.org, chromium-reviews, johnme+watch_chromium.org, Peter Beverloo, tfarina, zea+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

//chrome/browser and //components F-L: Change ScopedTempDir::path() to GetPath() path() is being deprecated, GetPath() has better checking against wrong use. For more context, see https://codereview.chromium.org/2275553005/. BUG=640599 Committed: https://crrev.com/0c237ae160c63e9870d588cfbc45c1709603b7a5 Cr-Commit-Position: refs/heads/master@{#418517}

Patch Set 1 #

Patch Set 2 : Add /chrome/common #

Patch Set 3 : //chrome/common F-L #

Patch Set 4 : Just rebased #

Patch Set 5 : Just rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -65 lines) Patch
M chrome/browser/file_select_helper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/history/android/android_cache_database_unittest.cc View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/history/android/android_provider_backend_unittest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/android/urls_sql_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/android/visit_sql_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/redirect_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/importer/edge_importer_browsertest_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/importer/firefox_importer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/firefox_profile_lock_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/importer/ie_importer_browsertest_win.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/lifetime/browser_close_manager_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/importer/firefox_importer_utils_unittest.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M components/filesystem/file_system_impl.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M components/gcm_driver/crypto/gcm_encryption_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/gcm_driver/crypto/gcm_key_store_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/gcm_driver/gcm_client_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/gcm_driver/gcm_driver_desktop_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/expire_history_backend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/history_backend_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/history/core/browser/history_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/history_querying_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/history_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/thumbnail_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/top_sites_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/top_sites_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/history/core/browser/typed_url_syncable_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/history/core/browser/url_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/browser/visit_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/history/core/test/history_backend_db_base_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/leveldb_proto/proto_database_impl_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
vabr (Chromium)
Hi Jochen, Could you please rubber-stamp? This is purely mechanical. Cheers, Vaclav P.S. Please let ...
4 years, 3 months ago (2016-09-13 20:24:28 UTC) #6
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-14 08:43:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2317003002/80001
4 years, 3 months ago (2016-09-14 09:19:34 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 3 months ago (2016-09-14 09:24:45 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 09:26:36 UTC) #12
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/0c237ae160c63e9870d588cfbc45c1709603b7a5
Cr-Commit-Position: refs/heads/master@{#418517}

Powered by Google App Engine
This is Rietveld 408576698