Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2320653002: Autofill and password_manager: Change ScopedTempDir::path() to GetPath() (Closed)

Created:
4 years, 3 months ago by vabr (Chromium)
Modified:
4 years, 3 months ago
Reviewers:
dvadym
CC:
chromium-reviews, vabr+watchlistpasswordmanager_chromium.org, rouslan+autofill_chromium.org, tfarina, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill and password_manager: Change ScopedTempDir::path() to GetPath() path() is being deprecated, GetPath() has better checking against wrong use. For more context, see https://codereview.chromium.org/2275553005/. BUG=640599 Committed: https://crrev.com/6b8cef6afc1219278f1fc13a40ea78a122b7961d Cr-Commit-Position: refs/heads/master@{#418537}

Patch Set 1 #

Patch Set 2 : Just rebased #

Patch Set 3 : Just rebased #

Patch Set 4 : Just rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -20 lines) Patch
M chrome/browser/password_manager/password_store_mac_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_proxy_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/password_store_win_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_x_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/simple_password_store_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/webdata/autofill_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/webdata/web_data_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/affiliation_database_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/import/password_importer_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/password_manager/core/browser/login_database_ios_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/login_database_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/password_manager/core/browser/password_store_default_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/statistics_table_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
vabr (Chromium)
Hi Vadym, Please review this completely mechanical change. It is just renaming and git cl ...
4 years, 3 months ago (2016-09-13 20:22:17 UTC) #10
dvadym
LGTM
4 years, 3 months ago (2016-09-14 11:58:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2320653002/60001
4 years, 3 months ago (2016-09-14 12:06:07 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-14 12:11:11 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 12:12:59 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6b8cef6afc1219278f1fc13a40ea78a122b7961d
Cr-Commit-Position: refs/heads/master@{#418537}

Powered by Google App Engine
This is Rietveld 408576698