chrome/browser/history/android/android_provider_backend_unittest.cc - Issue 2317003002: //chrome/browser and //components F-L: Change ScopedTempDir::path() to GetPath()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/history/android/android_provider_backend_unittest.cc

Issue 2317003002: //chrome/browser and //components F-L: Change ScopedTempDir::path() to GetPath() (Closed)

Patch Set: Just rebased Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/history/android/android_cache_database_unittest.cc ('k') | chrome/browser/history/android/bookmark_model_sql_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/history/android/android_provider_backend_unittest.cc

diff --git a/chrome/browser/history/android/android_provider_backend_unittest.cc b/chrome/browser/history/android/android_provider_backend_unittest.cc

index 00d38f0f813b4e96f1fa3da340fc83f3f6d9abc3..f12360e0c9254657d9d37193e1ddd8b33737ab41 100644

--- a/chrome/browser/history/android/android_provider_backend_unittest.cc

+++ b/chrome/browser/history/android/android_provider_backend_unittest.cc

@@ -201,10 +201,10 @@ class AndroidProviderBackendTest : public testing::Test {

// Setup the database directory and files.

ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());

- history_db_name_ = temp_dir_.path().AppendASCII(kHistoryFilename);

- thumbnail_db_name_ = temp_dir_.path().AppendASCII(kFaviconsFilename);

- android_cache_db_name_ = temp_dir_.path().AppendASCII(

- "TestAndroidCache.db");

+ history_db_name_ = temp_dir_.GetPath().AppendASCII(kHistoryFilename);

+ thumbnail_db_name_ = temp_dir_.GetPath().AppendASCII(kFaviconsFilename);

+ android_cache_db_name_ =

+ temp_dir_.GetPath().AppendASCII("TestAndroidCache.db");

}

void AddBookmark(const GURL& url) {

@@ -305,7 +305,7 @@ TEST_F(AndroidProviderBackendTest, UpdateTables) {

history_client_->CreateBackendClient(),

message_loop_.task_runner());

history_backend->Init(false,

- TestHistoryDatabaseParamsForPath(temp_dir_.path()));

+ TestHistoryDatabaseParamsForPath(temp_dir_.GetPath()));

history_backend->AddVisits(url1, visits1, history::SOURCE_SYNCED);

history_backend->AddVisits(url2, visits2, history::SOURCE_SYNCED);

URLRow url_row;

@@ -441,7 +441,7 @@ TEST_F(AndroidProviderBackendTest, QueryHistoryAndBookmarks) {

history_client_->CreateBackendClient(),

message_loop_.task_runner());

history_backend->Init(false,

- TestHistoryDatabaseParamsForPath(temp_dir_.path()));

+ TestHistoryDatabaseParamsForPath(temp_dir_.GetPath()));

history_backend->AddVisits(url1, visits1, history::SOURCE_SYNCED);

history_backend->AddVisits(url2, visits2, history::SOURCE_SYNCED);

@@ -1829,7 +1829,7 @@ TEST_F(AndroidProviderBackendTest, QueryWithoutThumbnailDB) {

history_client_->CreateBackendClient(),

message_loop_.task_runner());

history_backend->Init(false,

- TestHistoryDatabaseParamsForPath(temp_dir_.path()));

+ TestHistoryDatabaseParamsForPath(temp_dir_.GetPath()));

history_backend->AddVisits(url1, visits1, history::SOURCE_SYNCED);

history_backend->AddVisits(url2, visits2, history::SOURCE_SYNCED);

URLRow url_row;