Use new Skia .gni file for sources, remove .gypis.

Use new Skia .gni file for sources, remove .gypis.

This incorporates the changes from the following Chrome Skia build modifications:

https://codereview.chromium.org/2301233002/
  This file is provided by the Skia repo so the GN Chrome build doesn't have
  to make assumptions about the location and layout of Skia's GYP files.

https://codereview.chromium.org/2299033006
  Remove Skia GYP files from Chromium tree.
  Inlines the contents into the GN build.

Committed: https://pdfium.googlesource.com/pdfium/+/784548a551dca9b07723cb10323934b7e078d93a

[brettw, 2016-09-06 16:59:03]

Description was changed from

==========
Use new Skia .gni file for sources, remove .gypis.

https://codereview.chromium.org/2301233002/
  This file is provided by the Skia repo so the GN Chrome build doesn't have
  to make assumptions about the location and layout of Skia's GYP files.

https://codereview.chromium.org/2299033006
  Remove Skia GYP files from Chromium tree.
  Inlines the contents into the GN build.
==========

to

==========
Use new Skia .gni file for sources, remove .gypis.

This incorporates the changes from the following Chrome Skia build
modifications:

https://codereview.chromium.org/2301233002/
  This file is provided by the Skia repo so the GN Chrome build doesn't have
  to make assumptions about the location and layout of Skia's GYP files.

https://codereview.chromium.org/2299033006
  Remove Skia GYP files from Chromium tree.
  Inlines the contents into the GN build.
==========

[brettw, 2016-09-06 16:59:03]

brettw@chromium.org changed reviewers:
+ jam@chromium.org

[brettw, 2016-09-06 16:59:34]

This is so I can reland this modification to Skia:
https://codereview.chromium.org/2316653003

[brettw, 2016-09-06 16:59:38]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 16:59:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 17:10:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 17:10:11]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-09-06 17:17:32]

On 2016/09/06 17:10:11, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Looks like this is causing issues with the experimental skia bots:

ERROR at //skia/BUILD.gn:8:1: Can't load input file.
import("//third_party/skia/gn/shared_sources.gni")
^------------------------------------------------
Unable to load:
  /b/build/slave/pdfium/build/pdfium/third_party/skia/gn/shared_sources.gni
I also checked in the secondary tree for:
 
/b/build/slave/pdfium/build/pdfium/build/secondary/third_party/skia/gn/shared_sources.gni
See //BUILD.gn:821:7: which caused the file to be included.
      "//skia",
      ^-------

[brettw, 2016-09-06 17:21:52]

dsinclair: Sorry, you haven't given me enough context. Where is this bot and
what does it do?

[brettw, 2016-09-06 17:23:40]

On 2016/09/06 17:21:52, brettw (ping on IM after 24h) wrote:
> dsinclair: Sorry, you haven't given me enough context. Where is this bot and
> what does it do?

Also, this patch hasn't landed. How is it causing issues?

[dsinclair, 2016-09-06 17:42:49]

On 2016/09/06 17:23:40, brettw (ping on IM after 24h) wrote:
> On 2016/09/06 17:21:52, brettw (ping on IM after 24h) wrote:
> > dsinclair: Sorry, you haven't given me enough context. Where is this bot and
> > what does it do?
> 
> Also, this patch hasn't landed. How is it causing issues?


Sorry, the experimental try bots. In 'Settings' of Rietveld if you select the
'Display experimental tryjob results' to 'On issues that have experimental
results' you should see the bot output for the skia bots.

The three runs from your patch set 1 are:

https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_skia/buil...
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_skia/builds...
https://build.chromium.org/p/tryserver.client.pdfium/builders/mac_skia/builds...

[brettw, 2016-09-06 17:59:11]

Roll Skia deps

[brettw, 2016-09-06 17:59:11]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 17:59:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-09-06 17:59:24]

Ah, I think I just need to update the Skia deps. Thanks.

[jam, 2016-09-06 18:03:16]

jam@chromium.org changed reviewers:
+ dsinclair@chromium.org

[jam, 2016-09-06 18:03:17]

Switching reviewers to dsinclair since he's working on pdfium full time.

[commit-bot: I haz the power, 2016-09-06 18:08:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 18:08:22]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-09-06 18:10:23]

Fixes

[brettw, 2016-09-06 18:10:24]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 18:10:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-09-06 18:19:34]

More path

[brettw, 2016-09-06 18:19:35]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 18:19:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 18:33:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 18:33:42]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-09-06 18:39:27]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-06 18:39:28]

lgtm

[commit-bot: I haz the power, 2016-09-06 18:39:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-06 18:39:48]

Description was changed from

==========
Use new Skia .gni file for sources, remove .gypis.

This incorporates the changes from the following Chrome Skia build
modifications:

https://codereview.chromium.org/2301233002/
  This file is provided by the Skia repo so the GN Chrome build doesn't have
  to make assumptions about the location and layout of Skia's GYP files.

https://codereview.chromium.org/2299033006
  Remove Skia GYP files from Chromium tree.
  Inlines the contents into the GN build.
==========

to

==========
Use new Skia .gni file for sources, remove .gypis.

This incorporates the changes from the following Chrome Skia build
modifications:

https://codereview.chromium.org/2301233002/
  This file is provided by the Skia repo so the GN Chrome build doesn't have
  to make assumptions about the location and layout of Skia's GYP files.

https://codereview.chromium.org/2299033006
  Remove Skia GYP files from Chromium tree.
  Inlines the contents into the GN build.

Committed:
https://pdfium.googlesource.com/pdfium/+/784548a551dca9b07723cb10323934b7e078...
==========

[commit-bot: I haz the power, 2016-09-06 18:39:49]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/784548a551dca9b07723cb10323934b7e078...