Remove Skia GYP files from Chromium tree.

Remove Skia GYP files from Chromium tree.

Inlines the contents into the GN build.

Committed: https://crrev.com/bca67f4b8226fcd29d33d82fdcc56673b758f2e8
Cr-Commit-Position: refs/heads/master@{#416328}

[brettw, 2016-09-02 18:22:26]

dotfile

[brettw, 2016-09-02 18:22:27]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-09-02 18:22:47]

brettw@chromium.org changed reviewers:
+ mtklein@chromium.org

[commit-bot: I haz the power, 2016-09-02 18:23:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-09-02 18:36:21]

lgtm

https://codereview.chromium.org/2299033006/diff/20001/skia/BUILD.gn
File skia/BUILD.gn (right):

https://codereview.chromium.org/2299033006/diff/20001/skia/BUILD.gn#newcode47
skia/BUILD.gn:47: chromium_skia_defines = [ "SK_IGNORE_DW_GRAY_FIX" ]
If you like I think we can just make line 67

  defines = [ "SK_IGNORE_DW_GRAY_FIX" ]

and remove 33-47?

I'm not sure we need to keep around all these long-winded explanations of the
various ways we can define things, where they should go, for how long, etc.

[brettw, 2016-09-02 19:05:27]

On 2016/09/02 18:36:21, mtklein_C wrote:
> lgtm
> 
> https://codereview.chromium.org/2299033006/diff/20001/skia/BUILD.gn
> File skia/BUILD.gn (right):
> 
> https://codereview.chromium.org/2299033006/diff/20001/skia/BUILD.gn#newcode47
> skia/BUILD.gn:47: chromium_skia_defines = [ "SK_IGNORE_DW_GRAY_FIX" ]
> If you like I think we can just make line 67
> 
>   defines = [ "SK_IGNORE_DW_GRAY_FIX" ]
> 
> and remove 33-47?
> 
> I'm not sure we need to keep around all these long-winded explanations of the
> various ways we can define things, where they should go, for how long, etc.

Thanks, if that's the case I just moved it to the skia config below so we don't
even need the separate variable. Should still be trivial to update.

[brettw, 2016-09-02 19:05:32]

The CQ bit was unchecked by brettw@chromium.org

[brettw, 2016-09-02 19:06:49]

defines

[brettw, 2016-09-02 19:06:50]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-09-02 19:06:50]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@chromium.org
Link to the patchset: https://codereview.chromium.org/2299033006/#ps40001
(title: "defines")

[commit-bot: I haz the power, 2016-09-02 19:07:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-09-02 19:18:46]

Just what I was thinking!  lgtm

[commit-bot: I haz the power, 2016-09-02 20:08:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-02 20:11:19]

Description was changed from

==========
Remove Skia GYP files from Chromium tree.

Inlines the contents into the GN build.
==========

to

==========
Remove Skia GYP files from Chromium tree.

Inlines the contents into the GN build.

Committed: https://crrev.com/bca67f4b8226fcd29d33d82fdcc56673b758f2e8
Cr-Commit-Position: refs/heads/master@{#416328}
==========

[commit-bot: I haz the power, 2016-09-02 20:11:20]

Patchset 3 (id:??) landed as
https://crrev.com/bca67f4b8226fcd29d33d82fdcc56673b758f2e8
Cr-Commit-Position: refs/heads/master@{#416328}