Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 2299033006: Remove Skia GYP files from Chromium tree. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
mtklein_C
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Skia GYP files from Chromium tree. Inlines the contents into the GN build. Committed: https://crrev.com/bca67f4b8226fcd29d33d82fdcc56673b758f2e8 Cr-Commit-Position: refs/heads/master@{#416328}

Patch Set 1 #

Patch Set 2 : dotfile #

Total comments: 1

Patch Set 3 : defines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -729 lines) Patch
M .gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M skia/BUILD.gn View 1 2 4 chunks +35 lines, -25 lines 0 comments Download
D skia/chromium_skia_defines.gypi View 1 chunk +0 lines, -25 lines 0 comments Download
D skia/skia.gyp View 1 chunk +0 lines, -210 lines 0 comments Download
D skia/skia_gn_files.gypi View 1 chunk +0 lines, -43 lines 0 comments Download
D skia/skia_library_opts.gyp View 1 chunk +0 lines, -345 lines 0 comments Download
D skia/skia_tests.gyp View 1 chunk +0 lines, -80 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
brettw
dotfile
4 years, 3 months ago (2016-09-02 18:22:26 UTC) #1
brettw
4 years, 3 months ago (2016-09-02 18:22:48 UTC) #4
mtklein_C
lgtm https://codereview.chromium.org/2299033006/diff/20001/skia/BUILD.gn File skia/BUILD.gn (right): https://codereview.chromium.org/2299033006/diff/20001/skia/BUILD.gn#newcode47 skia/BUILD.gn:47: chromium_skia_defines = [ "SK_IGNORE_DW_GRAY_FIX" ] If you like ...
4 years, 3 months ago (2016-09-02 18:36:21 UTC) #6
brettw
On 2016/09/02 18:36:21, mtklein_C wrote: > lgtm > > https://codereview.chromium.org/2299033006/diff/20001/skia/BUILD.gn > File skia/BUILD.gn (right): > ...
4 years, 3 months ago (2016-09-02 19:05:27 UTC) #7
brettw
defines
4 years, 3 months ago (2016-09-02 19:06:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2299033006/40001
4 years, 3 months ago (2016-09-02 19:07:31 UTC) #12
mtklein_C
Just what I was thinking! lgtm
4 years, 3 months ago (2016-09-02 19:18:46 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-02 20:08:44 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-02 20:11:20 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bca67f4b8226fcd29d33d82fdcc56673b758f2e8
Cr-Commit-Position: refs/heads/master@{#416328}

Powered by Google App Engine
This is Rietveld 408576698