Add GM/slide to simulate Android-style reveal clip

Add GM/slide to simulate Android-style reveal clip

Hopefully, this will let us play w/ geometric and shader-based solutions.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003

Committed: https://skia.googlesource.com/skia/+/ffac5c4aae18fc706e4077763c190a89c8507fb0
Committed: https://skia.googlesource.com/skia/+/05a4cf59591024d838b204bb0f6fac42598ead28

[robertphillips, 2016-09-06 17:31:19]

Description was changed from

==========
Add GM/slide to simulate Android-style reveal clip
==========

to

==========
Add GM/slide to simulate Android-style reveal clip
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003
==========

[robertphillips, 2016-09-06 17:36:28]

Description was changed from

==========
Add GM/slide to simulate Android-style reveal clip
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003
==========

to

==========
Add GM/slide to simulate Android-style reveal clip
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003
==========

[robertphillips, 2016-09-06 17:36:28]

robertphillips@google.com changed reviewers:
+ djsollen@google.com, jvanverth@google.com

[robertphillips, 2016-09-06 17:36:53]

Description was changed from

==========
Add GM/slide to simulate Android-style reveal clip
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003
==========

to

==========
Add GM/slide to simulate Android-style reveal clip

Hopefully, this will let us play w/ geometric and shader-based solutions.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003
==========

[jvanverth1, 2016-09-07 14:03:05]

lgtm

[robertphillips, 2016-09-07 14:46:40]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 14:46:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 14:49:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 14:49:34]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[djsollen, 2016-09-07 15:03:11]

lgtm

lgtm

[robertphillips, 2016-09-07 15:04:33]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 15:04:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 15:13:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 15:13:34]

Dry run: Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on
master.client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[robertphillips, 2016-09-07 16:56:06]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 16:56:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 17:31:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 17:31:32]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-09-07 17:33:08]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-09-07 17:33:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
jvanverth@google.com, djsollen@google.com
Link to the patchset: https://codereview.chromium.org/2316593003/#ps100001
(title: "Fix serialization")

[commit-bot: I haz the power, 2016-09-07 17:33:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 17:34:08]

Description was changed from

==========
Add GM/slide to simulate Android-style reveal clip

Hopefully, this will let us play w/ geometric and shader-based solutions.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003
==========

to

==========
Add GM/slide to simulate Android-style reveal clip

Hopefully, this will let us play w/ geometric and shader-based solutions.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003

Committed:
https://skia.googlesource.com/skia/+/ffac5c4aae18fc706e4077763c190a89c8507fb0
==========

[commit-bot: I haz the power, 2016-09-07 17:34:09]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/ffac5c4aae18fc706e4077763c190a89c8507fb0

[robertphillips, 2016-09-07 18:33:51]

A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/2316303002/ by robertphillips@google.com.

The reason for reverting is: Shader compilation failure.

[robertphillips, 2016-09-07 19:03:51]

Description was changed from

==========
Add GM/slide to simulate Android-style reveal clip

Hopefully, this will let us play w/ geometric and shader-based solutions.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003

Committed:
https://skia.googlesource.com/skia/+/ffac5c4aae18fc706e4077763c190a89c8507fb0
==========

to

==========
Add GM/slide to simulate Android-style reveal clip

Hopefully, this will let us play w/ geometric and shader-based solutions.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003

Committed:
https://skia.googlesource.com/skia/+/ffac5c4aae18fc706e4077763c190a89c8507fb0
==========

[robertphillips, 2016-09-08 12:57:45]

Description was changed from

==========
Add GM/slide to simulate Android-style reveal clip

Hopefully, this will let us play w/ geometric and shader-based solutions.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003

Committed:
https://skia.googlesource.com/skia/+/ffac5c4aae18fc706e4077763c190a89c8507fb0
==========

to

==========
Add GM/slide to simulate Android-style reveal clip

Hopefully, this will let us play w/ geometric and shader-based solutions.

This needs to land after: https://codereview.chromium.org/2326503002/ (Add
default version of fsDistanceVector if it is required but not implemented)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003

Committed:
https://skia.googlesource.com/skia/+/ffac5c4aae18fc706e4077763c190a89c8507fb0
==========

[robertphillips, 2016-09-08 12:58:24]

PTAL. I've added an SkBlurMaskFilter path and made GM's able to respond to key
presses in SampleApp.

[jvanverth1, 2016-09-08 14:04:18]

lgtm

Does this fix the shader issue?

[robertphillips, 2016-09-08 14:08:27]

Description was changed from

==========
Add GM/slide to simulate Android-style reveal clip

Hopefully, this will let us play w/ geometric and shader-based solutions.

This needs to land after: https://codereview.chromium.org/2326503002/ (Add
default version of fsDistanceVector if it is required but not implemented)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003

Committed:
https://skia.googlesource.com/skia/+/ffac5c4aae18fc706e4077763c190a89c8507fb0
==========

to

==========
Add GM/slide to simulate Android-style reveal clip

Hopefully, this will let us play w/ geometric and shader-based solutions.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003

Committed:
https://skia.googlesource.com/skia/+/ffac5c4aae18fc706e4077763c190a89c8507fb0
==========

[robertphillips, 2016-09-08 14:08:27]

robertphillips@google.com changed reviewers:
+ egdaniel@google.com

[robertphillips, 2016-09-08 14:09:01]

On 2016/09/08 14:04:18, jvanverth1 wrote:
> lgtm
> 
> Does this fix the shader issue?

I had split that out into a separate CL. After talking with Greg a different
(more explicit) approach is in this CL.

[jvanverth1, 2016-09-08 14:15:52]

https://codereview.chromium.org/2316593003/diff/150001/src/effects/SkGaussian...
File src/effects/SkGaussianEdgeShader.cpp (right):

https://codereview.chromium.org/2316593003/diff/150001/src/effects/SkGaussian...
src/effects/SkGaussianEdgeShader.cpp:75: fragBuilder->codeAppendf("%s = vec4(0,
0, 0, 0);", args.fOutputColor);
Maybe (0, 0, 0, color.r) instead? At least you'd get the right shade without the
blurred edge.

[egdaniel, 2016-09-08 14:31:09]

nit

https://codereview.chromium.org/2316593003/diff/170001/src/effects/SkGaussian...
File src/effects/SkGaussianEdgeShader.cpp (right):

https://codereview.chromium.org/2316593003/diff/170001/src/effects/SkGaussian...
src/effects/SkGaussianEdgeShader.cpp:81: fragBuilder->codeAppendf("float factor
= 1.0 - clamp((%s.z - pad)/radius, 0.0, 1.0);",
100 chars

[robertphillips, 2016-09-08 14:34:50]

https://codereview.chromium.org/2316593003/diff/150001/src/effects/SkGaussian...
File src/effects/SkGaussianEdgeShader.cpp (right):

https://codereview.chromium.org/2316593003/diff/150001/src/effects/SkGaussian...
src/effects/SkGaussianEdgeShader.cpp:75: fragBuilder->codeAppendf("%s = vec4(0,
0, 0, 0);", args.fOutputColor);
On 2016/09/08 14:15:52, jvanverth1 wrote:
> Maybe (0, 0, 0, color.r) instead? At least you'd get the right shade without
the
> blurred edge.

Done.

https://codereview.chromium.org/2316593003/diff/170001/src/effects/SkGaussian...
File src/effects/SkGaussianEdgeShader.cpp (right):

https://codereview.chromium.org/2316593003/diff/170001/src/effects/SkGaussian...
src/effects/SkGaussianEdgeShader.cpp:81: fragBuilder->codeAppendf("float factor
= 1.0 - clamp((%s.z - pad)/radius, 0.0, 1.0);",
On 2016/09/08 14:31:09, egdaniel wrote:
> 100 chars

Done.

[robertphillips, 2016-09-08 14:34:58]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 14:35:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 14:57:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 14:57:17]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-09-08 16:01:18]

The CQ bit was checked by robertphillips@google.com

[robertphillips, 2016-09-08 16:01:19]

The patchset sent to the CQ was uploaded after l-g-t-m from djsollen@google.com,
jvanverth@google.com
Link to the patchset: https://codereview.chromium.org/2316593003/#ps210001
(title: "address code review comments")

[commit-bot: I haz the power, 2016-09-08 16:01:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 16:02:45]

Description was changed from

==========
Add GM/slide to simulate Android-style reveal clip

Hopefully, this will let us play w/ geometric and shader-based solutions.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003

Committed:
https://skia.googlesource.com/skia/+/ffac5c4aae18fc706e4077763c190a89c8507fb0
==========

to

==========
Add GM/slide to simulate Android-style reveal clip

Hopefully, this will let us play w/ geometric and shader-based solutions.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316593003

Committed:
https://skia.googlesource.com/skia/+/ffac5c4aae18fc706e4077763c190a89c8507fb0
Committed:
https://skia.googlesource.com/skia/+/05a4cf59591024d838b204bb0f6fac42598ead28
==========

[commit-bot: I haz the power, 2016-09-08 16:02:46]

Committed patchset #12 (id:210001) as
https://skia.googlesource.com/skia/+/05a4cf59591024d838b204bb0f6fac42598ead28