Include only stuff you need, part 8: Fix debug.h -> liveedit.h.

Include only stuff you need, part 8: Fix debug.h -> liveedit.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

The (last remaining) offending include path is: ast.h <- liveedit.h <-
debug.h <- src/x64/assembler-whatever-port-inl.h <-
src/macro-assembler.h <- everything possible

With this CL, the rebuild steps needed when touching ast-value-factory.h
drops from 365 to 181.

BUG=v8:5294
TBR=bmeurer@chromium.org

Committed: https://crrev.com/51a3ffd9f14eee651fd61e1c4443dc15c252f42b
Cr-Commit-Position: refs/heads/master@{#39195}

[marja, 2016-09-05 12:29:32]

Description was changed from

==========
Include only stuff you need, part 8: Fix debug.h -> liveedit.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

The (last remaining) offending include path is: ast.h <- liveedit.h <-
debug.h <- src/x64/assembler-whatever-porty-inl.h <-
src/macro-assembler.h <- everything possible

With this CL, the rebuild steps needed when touching ast-value-factory.h
drops from 365 to 181.

BUG=v8:5294
==========

to

==========
Include only stuff you need, part 8: Fix debug.h -> liveedit.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

The (last remaining) offending include path is: ast.h <- liveedit.h <-
debug.h <- src/x64/assembler-whatever-port-inl.h <-
src/macro-assembler.h <- everything possible

With this CL, the rebuild steps needed when touching ast-value-factory.h
drops from 365 to 181.

BUG=v8:5294
==========

[marja, 2016-09-05 12:30:03]

The CQ bit was checked by marja@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 12:30:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 12:55:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 12:55:32]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2016-09-06 08:05:37]

mstarzinger@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[Michael Starzinger, 2016-09-06 08:05:38]

You will also need a debugger owner for this.

https://codereview.chromium.org/2316443002/diff/20001/src/compiler/js-generic...
File src/compiler/js-generic-lowering.cc (right):

https://codereview.chromium.org/2316443002/diff/20001/src/compiler/js-generic...
src/compiler/js-generic-lowering.cc:5: #include
"src/compiler/js-generic-lowering.h"
nit: Can we add an empty newline after the first include, to make it visually
obvious that it is the very first one on purpose. WDYT?

https://codereview.chromium.org/2316443002/diff/20001/src/debug/arm/debug-arm.cc
File src/debug/arm/debug-arm.cc (right):

https://codereview.chromium.org/2316443002/diff/20001/src/debug/arm/debug-arm...
src/debug/arm/debug-arm.cc:7: #include "src/debug/debug.h"
nit: Can we add an empty newline after the first include, to make it visually
obvious that it is the very first one on purpose. WDYT?

https://codereview.chromium.org/2316443002/diff/20001/src/debug/live-edit-fra...
File src/debug/live-edit-frame-drop-mode.h (right):

https://codereview.chromium.org/2316443002/diff/20001/src/debug/live-edit-fra...
src/debug/live-edit-frame-drop-mode.h:5: #ifndef
V8_DEBUG_LIVEEDIT_FRAME_DROP_MODE_H_
nit: Let's call the file "liveedit-frame-drop-mode.h" without the first hyphen
to be consistent with everything else.

Also, the file should be added to BUILD.gn and v8.gyp I think.

Alternatively, could we just add this enum do globals.h and call it a day? It's
a little bit less clean but avoids the additional file. Just a suggestion.

[marja, 2016-09-06 08:24:07]

thanks for comments!

https://codereview.chromium.org/2316443002/diff/20001/src/compiler/js-generic...
File src/compiler/js-generic-lowering.cc (right):

https://codereview.chromium.org/2316443002/diff/20001/src/compiler/js-generic...
src/compiler/js-generic-lowering.cc:5: #include
"src/compiler/js-generic-lowering.h"
On 2016/09/06 08:05:38, Michael Starzinger wrote:
> nit: Can we add an empty newline after the first include, to make it visually
> obvious that it is the very first one on purpose. WDYT?

Done.

https://codereview.chromium.org/2316443002/diff/20001/src/debug/arm/debug-arm.cc
File src/debug/arm/debug-arm.cc (right):

https://codereview.chromium.org/2316443002/diff/20001/src/debug/arm/debug-arm...
src/debug/arm/debug-arm.cc:7: #include "src/debug/debug.h"
On 2016/09/06 08:05:38, Michael Starzinger wrote:
> nit: Can we add an empty newline after the first include, to make it visually
> obvious that it is the very first one on purpose. WDYT?

Done.

https://codereview.chromium.org/2316443002/diff/20001/src/debug/live-edit-fra...
File src/debug/live-edit-frame-drop-mode.h (right):

https://codereview.chromium.org/2316443002/diff/20001/src/debug/live-edit-fra...
src/debug/live-edit-frame-drop-mode.h:5: #ifndef
V8_DEBUG_LIVEEDIT_FRAME_DROP_MODE_H_
On 2016/09/06 08:05:38, Michael Starzinger wrote:
> nit: Let's call the file "liveedit-frame-drop-mode.h" without the first hyphen
> to be consistent with everything else.
> 
> Also, the file should be added to BUILD.gn and v8.gyp I think.
> 
> Alternatively, could we just add this enum do globals.h and call it a day?
It's
> a little bit less clean but avoids the additional file. Just a suggestion.

Moved to globals.h

[Michael Starzinger, 2016-09-06 08:29:53]

LGTM from my end.

[marja, 2016-09-06 08:31:34]

Description was changed from

==========
Include only stuff you need, part 8: Fix debug.h -> liveedit.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

The (last remaining) offending include path is: ast.h <- liveedit.h <-
debug.h <- src/x64/assembler-whatever-port-inl.h <-
src/macro-assembler.h <- everything possible

With this CL, the rebuild steps needed when touching ast-value-factory.h
drops from 365 to 181.

BUG=v8:5294
==========

to

==========
Include only stuff you need, part 8: Fix debug.h -> liveedit.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

The (last remaining) offending include path is: ast.h <- liveedit.h <-
debug.h <- src/x64/assembler-whatever-port-inl.h <-
src/macro-assembler.h <- everything possible

With this CL, the rebuild steps needed when touching ast-value-factory.h
drops from 365 to 181.

BUG=v8:5294
TBR=bmeurer@chromium.org
==========

[marja, 2016-09-06 08:32:02]

marja@chromium.org changed reviewers:
+ bmeurer@chromium.org

[marja, 2016-09-06 08:32:03]

thanks for review - TBR:ing this to bmeurer@ as discussed offline.

[marja, 2016-09-06 08:32:15]

The CQ bit was checked by marja@chromium.org

[commit-bot: I haz the power, 2016-09-06 08:32:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Benedikt Meurer, 2016-09-06 08:47:32]

LGTM (rubberstamped)

[commit-bot: I haz the power, 2016-09-06 08:59:44]

Description was changed from

==========
Include only stuff you need, part 8: Fix debug.h -> liveedit.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

The (last remaining) offending include path is: ast.h <- liveedit.h <-
debug.h <- src/x64/assembler-whatever-port-inl.h <-
src/macro-assembler.h <- everything possible

With this CL, the rebuild steps needed when touching ast-value-factory.h
drops from 365 to 181.

BUG=v8:5294
TBR=bmeurer@chromium.org
==========

to

==========
Include only stuff you need, part 8: Fix debug.h -> liveedit.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

The (last remaining) offending include path is: ast.h <- liveedit.h <-
debug.h <- src/x64/assembler-whatever-port-inl.h <-
src/macro-assembler.h <- everything possible

With this CL, the rebuild steps needed when touching ast-value-factory.h
drops from 365 to 181.

BUG=v8:5294
TBR=bmeurer@chromium.org
==========

[commit-bot: I haz the power, 2016-09-06 08:59:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-06 09:00:37]

Description was changed from

==========
Include only stuff you need, part 8: Fix debug.h -> liveedit.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

The (last remaining) offending include path is: ast.h <- liveedit.h <-
debug.h <- src/x64/assembler-whatever-port-inl.h <-
src/macro-assembler.h <- everything possible

With this CL, the rebuild steps needed when touching ast-value-factory.h
drops from 365 to 181.

BUG=v8:5294
TBR=bmeurer@chromium.org
==========

to

==========
Include only stuff you need, part 8: Fix debug.h -> liveedit.h.

Rebuilding (after touching certain files) is crazy slow because
includes are out of control.

The (last remaining) offending include path is: ast.h <- liveedit.h <-
debug.h <- src/x64/assembler-whatever-port-inl.h <-
src/macro-assembler.h <- everything possible

With this CL, the rebuild steps needed when touching ast-value-factory.h
drops from 365 to 181.

BUG=v8:5294
TBR=bmeurer@chromium.org

Committed: https://crrev.com/51a3ffd9f14eee651fd61e1c4443dc15c252f42b
Cr-Commit-Position: refs/heads/master@{#39195}
==========

[commit-bot: I haz the power, 2016-09-06 09:00:38]

Patchset 4 (id:??) landed as
https://crrev.com/51a3ffd9f14eee651fd61e1c4443dc15c252f42b
Cr-Commit-Position: refs/heads/master@{#39195}