Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Side by Side Diff: src/debug/debug.cc

Issue 2316443002: Include only stuff you need, part 8: Fix debug.h -> liveedit.h. (Closed)
Patch Set: code review (mstarzinger@) Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/debug.h ('k') | src/debug/debug-scopes.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/debug.h" 5 #include "src/debug/debug.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "src/api.h" 9 #include "src/api.h"
10 #include "src/arguments.h" 10 #include "src/arguments.h"
11 #include "src/bootstrapper.h" 11 #include "src/bootstrapper.h"
12 #include "src/code-stubs.h" 12 #include "src/code-stubs.h"
13 #include "src/codegen.h" 13 #include "src/codegen.h"
14 #include "src/compilation-cache.h" 14 #include "src/compilation-cache.h"
15 #include "src/compiler-dispatcher/optimizing-compile-dispatcher.h" 15 #include "src/compiler-dispatcher/optimizing-compile-dispatcher.h"
16 #include "src/compiler.h" 16 #include "src/compiler.h"
17 #include "src/debug/liveedit.h"
17 #include "src/deoptimizer.h" 18 #include "src/deoptimizer.h"
18 #include "src/execution.h" 19 #include "src/execution.h"
19 #include "src/frames-inl.h" 20 #include "src/frames-inl.h"
20 #include "src/full-codegen/full-codegen.h" 21 #include "src/full-codegen/full-codegen.h"
21 #include "src/global-handles.h" 22 #include "src/global-handles.h"
22 #include "src/globals.h" 23 #include "src/globals.h"
23 #include "src/interpreter/interpreter.h" 24 #include "src/interpreter/interpreter.h"
24 #include "src/isolate-inl.h" 25 #include "src/isolate-inl.h"
25 #include "src/list.h" 26 #include "src/list.h"
26 #include "src/log.h" 27 #include "src/log.h"
(...skipping 1542 matching lines...) Expand 10 before | Expand all | Expand 10 after
1569 1570
1570 // With no debug info there are no break points, so we can't be at a return. 1571 // With no debug info there are no break points, so we can't be at a return.
1571 if (!shared->HasDebugInfo()) return false; 1572 if (!shared->HasDebugInfo()) return false;
1572 1573
1573 DCHECK(!frame->is_optimized()); 1574 DCHECK(!frame->is_optimized());
1574 Handle<DebugInfo> debug_info(shared->GetDebugInfo()); 1575 Handle<DebugInfo> debug_info(shared->GetDebugInfo());
1575 BreakLocation location = BreakLocation::FromFrame(debug_info, frame); 1576 BreakLocation location = BreakLocation::FromFrame(debug_info, frame);
1576 return location.IsReturn() || location.IsTailCall(); 1577 return location.IsReturn() || location.IsTailCall();
1577 } 1578 }
1578 1579
1579
1580 void Debug::FramesHaveBeenDropped(StackFrame::Id new_break_frame_id, 1580 void Debug::FramesHaveBeenDropped(StackFrame::Id new_break_frame_id,
1581 LiveEdit::FrameDropMode mode) { 1581 LiveEditFrameDropMode mode) {
1582 if (mode != LiveEdit::CURRENTLY_SET_MODE) { 1582 if (mode != LIVE_EDIT_CURRENTLY_SET_MODE) {
1583 thread_local_.frame_drop_mode_ = mode; 1583 thread_local_.frame_drop_mode_ = mode;
1584 } 1584 }
1585 thread_local_.break_frame_id_ = new_break_frame_id; 1585 thread_local_.break_frame_id_ = new_break_frame_id;
1586 } 1586 }
1587 1587
1588 1588
1589 bool Debug::IsDebugGlobal(JSGlobalObject* global) { 1589 bool Debug::IsDebugGlobal(JSGlobalObject* global) {
1590 return is_loaded() && global == debug_context()->global_object(); 1590 return is_loaded() && global == debug_context()->global_object();
1591 } 1591 }
1592 1592
(...skipping 973 matching lines...) Expand 10 before | Expand all | Expand 10 after
2566 } 2566 }
2567 2567
2568 2568
2569 void LockingCommandMessageQueue::Clear() { 2569 void LockingCommandMessageQueue::Clear() {
2570 base::LockGuard<base::Mutex> lock_guard(&mutex_); 2570 base::LockGuard<base::Mutex> lock_guard(&mutex_);
2571 queue_.Clear(); 2571 queue_.Clear();
2572 } 2572 }
2573 2573
2574 } // namespace internal 2574 } // namespace internal
2575 } // namespace v8 2575 } // namespace v8
OLDNEW
« no previous file with comments | « src/debug/debug.h ('k') | src/debug/debug-scopes.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698