Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2316373003:
Presubmit: Warn about using XSelectInput (Closed)
|
Created:
4 years, 3 months ago by Tom (Use chromium acct) Modified:
4 years, 3 months ago Reviewers:
Dirk Pranke CC:
chromium-reviews, Elliot Glaysher, Daniel Erat Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPresubmit: Warn about using XSelectInput
New code running in the browser process should always use
ui::XScopedEventSelector instead of XSelectInput.
BUG=634084
Committed: https://crrev.com/4b56905d6ab61e9e14f991a7458d8968635cfef2
Cr-Commit-Position: refs/heads/master@{#418653}
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Update dependent patch set #
Depends on Patchset: Messages
Total messages: 24 (19 generated)
Description was changed from ========== Presubmit: Warn about using XSelectInput ========== to ========== Presubmit: Warn about using XSelectInput New code running in the browser process should always use ui::XScopedEventSelector instead of XSelectInput. BUG=634084 ==========
thomasanderson@google.com changed reviewers: + dpranke@chromium.org
Patchset #1 (id:1) has been deleted
Description was changed from ========== Presubmit: Warn about using XSelectInput New code running in the browser process should always use ui::XScopedEventSelector instead of XSelectInput. BUG=634084 ========== to ========== Presubmit: Warn about using XSelectInput New code running in the browser process should always use ui::XScopedEventSelector instead of XSelectInput. BUG=634084 ==========
+dpranke@ for review +erg@ and derat@ FYI
lgtm
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Patchset #4 (id:80001) has been deleted
Patchset #2 (id:40001) has been deleted
Patchset #2 (id:60001) has been deleted
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thomasanderson@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org Link to the patchset: https://codereview.chromium.org/2316373003/#ps120001 (title: "Update dependent patch set")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Presubmit: Warn about using XSelectInput New code running in the browser process should always use ui::XScopedEventSelector instead of XSelectInput. BUG=634084 ========== to ========== Presubmit: Warn about using XSelectInput New code running in the browser process should always use ui::XScopedEventSelector instead of XSelectInput. BUG=634084 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Presubmit: Warn about using XSelectInput New code running in the browser process should always use ui::XScopedEventSelector instead of XSelectInput. BUG=634084 ========== to ========== Presubmit: Warn about using XSelectInput New code running in the browser process should always use ui::XScopedEventSelector instead of XSelectInput. BUG=634084 Committed: https://crrev.com/4b56905d6ab61e9e14f991a7458d8968635cfef2 Cr-Commit-Position: refs/heads/master@{#418653} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4b56905d6ab61e9e14f991a7458d8968635cfef2 Cr-Commit-Position: refs/heads/master@{#418653} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
