| OLD | NEW |
| 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 157 ( | 157 ( |
| 158 'FRIEND_TEST(', | 158 'FRIEND_TEST(', |
| 159 ( | 159 ( |
| 160 'Chromium code should not use gtest\'s FRIEND_TEST() macro. Include', | 160 'Chromium code should not use gtest\'s FRIEND_TEST() macro. Include', |
| 161 'base/gtest_prod_util.h and use FRIEND_TEST_ALL_PREFIXES() instead.', | 161 'base/gtest_prod_util.h and use FRIEND_TEST_ALL_PREFIXES() instead.', |
| 162 ), | 162 ), |
| 163 False, | 163 False, |
| 164 (), | 164 (), |
| 165 ), | 165 ), |
| 166 ( | 166 ( |
| 167 r'XSelectInput|CWEventMask|XCB_CW_EVENT_MASK', |
| 168 ( |
| 169 'Chrome clients wishing to select events on X windows should use', |
| 170 'ui::XScopedEventSelector. It is safe to ignore this warning only if', |
| 171 'you are selecting events from the GPU process, or if you are using', |
| 172 'an XDisplay other than gfx::GetXDisplay().', |
| 173 ), |
| 174 True, |
| 175 ( |
| 176 r"^ui[\\\/]gl[\\\/].*\.cc$", |
| 177 r"^media[\\\/]gpu[\\\/].*\.cc$", |
| 178 r"^gpu[\\\/].*\.cc$", |
| 179 ), |
| 180 ), |
| 181 ( |
| 167 'ScopedAllowIO', | 182 'ScopedAllowIO', |
| 168 ( | 183 ( |
| 169 'New code should not use ScopedAllowIO. Post a task to the blocking', | 184 'New code should not use ScopedAllowIO. Post a task to the blocking', |
| 170 'pool or the FILE thread instead.', | 185 'pool or the FILE thread instead.', |
| 171 ), | 186 ), |
| 172 True, | 187 True, |
| 173 ( | 188 ( |
| 174 r"^base[\\\/]process[\\\/]process_linux\.cc$", | 189 r"^base[\\\/]process[\\\/]process_linux\.cc$", |
| 175 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$", | 190 r"^base[\\\/]process[\\\/]process_metrics_linux\.cc$", |
| 176 r"^blimp[\\\/]engine[\\\/]app[\\\/]blimp_browser_main_parts\.cc$", | 191 r"^blimp[\\\/]engine[\\\/]app[\\\/]blimp_browser_main_parts\.cc$", |
| (...skipping 2078 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 2255 results.extend(input_api.canned_checks.CheckTreeIsOpen( | 2270 results.extend(input_api.canned_checks.CheckTreeIsOpen( |
| 2256 input_api, | 2271 input_api, |
| 2257 output_api, | 2272 output_api, |
| 2258 json_url='http://chromium-status.appspot.com/current?format=json')) | 2273 json_url='http://chromium-status.appspot.com/current?format=json')) |
| 2259 | 2274 |
| 2260 results.extend(input_api.canned_checks.CheckChangeHasBugField( | 2275 results.extend(input_api.canned_checks.CheckChangeHasBugField( |
| 2261 input_api, output_api)) | 2276 input_api, output_api)) |
| 2262 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 2277 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
| 2263 input_api, output_api)) | 2278 input_api, output_api)) |
| 2264 return results | 2279 return results |
| OLD | NEW |